batman-adv: Check return value of try_module_get

New operations should not be started when they need an increased module
reference counter and try_module_get failed.

This patch addresses Coverity #712284: Unchecked return value

Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Antonio Quartulli <ordex@autistici.org>

1 files changed, 8 insertions, 4 deletions

diff --git a/net/batman-adv/icmp_socket.c b/net/batman-adv/icmp_socket.c
index bde3cf747507..5874c0e84846 100644
--- a/net/batman-adv/icmp_socket.c
+++ b/net/batman-adv/icmp_socket.c
@@ -42,12 +42,16 @@ static int batadv_socket_open(struct inode *inode, struct file *file)
         unsigned int i;
         struct batadv_socket_client *socket_client;
 
+        if (!try_module_get(THIS_MODULE))
+                return -EBUSY;
+
         nonseekable_open(inode, file);
 
         socket_client = kmalloc(sizeof(*socket_client), GFP_KERNEL);
-
-        if (!socket_client)
+        if (!socket_client) {
+                module_put(THIS_MODULE);
                 return -ENOMEM;
+        }
 
         for (i = 0; i < ARRAY_SIZE(batadv_socket_client_hash); i++) {
                 if (!batadv_socket_client_hash[i]) {
@@ -59,6 +63,7 @@ static int batadv_socket_open(struct inode *inode, struct file *file)
         if (i == ARRAY_SIZE(batadv_socket_client_hash)) {
                 pr_err("Error - can't add another packet client: maximum number of clients reached\n");
                 kfree(socket_client);
+                module_put(THIS_MODULE);
                 return -EXFULL;
         }
 
@@ -71,7 +76,6 @@ static int batadv_socket_open(struct inode *inode, struct file *file)
 
         file->private_data = socket_client;
 
-        batadv_inc_module_count();
         return 0;
 }
 
@@ -96,7 +100,7 @@ static int batadv_socket_release(struct inode *inode, struct file *file)
         spin_unlock_bh(&socket_client->lock);
 
         kfree(socket_client);
-        batadv_dec_module_count();
+        module_put(THIS_MODULE);
 
         return 0;
 }