batman-adv: Calculate sizeof using variable insead of types

Documentation/CodingStyle recommends to use the form

	p = kmalloc(sizeof(*p), ...);

to calculate the size of a struct and not the version where the struct
name is spelled out to prevent bugs when the type of p changes. This
also seems appropriate for manipulation of buffers when they are
directly associated with p.

Signed-off-by: Sven Eckelmann <sven@narfation.org>

1 files changed, 6 insertions, 6 deletions

diff --git a/net/batman-adv/gateway_client.c b/net/batman-adv/gateway_client.c
index e9c7eb1a1f9d..a44dff3efb7f 100644
--- a/net/batman-adv/gateway_client.c
+++ b/net/batman-adv/gateway_client.c
@@ -273,7 +273,7 @@ static void gw_node_add(struct bat_priv *bat_priv,
         struct gw_node *gw_node;
         int down, up;
 
-        gw_node = kzalloc(sizeof(struct gw_node), GFP_ATOMIC);
+        gw_node = kzalloc(sizeof(*gw_node), GFP_ATOMIC);
         if (!gw_node)
                 return;
 
@@ -508,7 +508,7 @@ int gw_is_target(struct bat_priv *bat_priv, struct sk_buff *skb)
         /* check for ip header */
         switch (ntohs(ethhdr->h_proto)) {
         case ETH_P_IP:
-                if (!pskb_may_pull(skb, header_len + sizeof(struct iphdr)))
+                if (!pskb_may_pull(skb, header_len + sizeof(*iphdr)))
                         return 0;
                 iphdr = (struct iphdr *)(skb->data + header_len);
                 header_len += iphdr->ihl * 4;
@@ -519,10 +519,10 @@ int gw_is_target(struct bat_priv *bat_priv, struct sk_buff *skb)
 
                 break;
         case ETH_P_IPV6:
-                if (!pskb_may_pull(skb, header_len + sizeof(struct ipv6hdr)))
+                if (!pskb_may_pull(skb, header_len + sizeof(*ipv6hdr)))
                         return 0;
                 ipv6hdr = (struct ipv6hdr *)(skb->data + header_len);
-                header_len += sizeof(struct ipv6hdr);
+                header_len += sizeof(*ipv6hdr);
 
                 /* check for udp header */
                 if (ipv6hdr->nexthdr != IPPROTO_UDP)
@@ -533,10 +533,10 @@ int gw_is_target(struct bat_priv *bat_priv, struct sk_buff *skb)
                 return 0;
         }
 
-        if (!pskb_may_pull(skb, header_len + sizeof(struct udphdr)))
+        if (!pskb_may_pull(skb, header_len + sizeof(*udphdr)))
                 return 0;
         udphdr = (struct udphdr *)(skb->data + header_len);
-        header_len += sizeof(struct udphdr);
+        header_len += sizeof(*udphdr);
 
         /* check for bootp port */
         if ((ntohs(ethhdr->h_proto) == ETH_P_IP) &&