diff options
author | Sven Eckelmann <sven@narfation.org> | 2012-08-20 17:37:26 -0400 |
---|---|---|
committer | Antonio Quartulli <ordex@autistici.org> | 2012-10-29 04:42:36 -0400 |
commit | bd5b80d51a6c4a68f7d4b9b92c495329f47e53d4 (patch) | |
tree | 8650acb5b824f001651186e1357f4b7666437330 /net/batman-adv/debugfs.c | |
parent | 8e7c15d6b5468f0dcdd887db1e5df88e629c00d6 (diff) |
batman-adv: Check return value of try_module_get
New operations should not be started when they need an increased module
reference counter and try_module_get failed.
This patch addresses Coverity #712284: Unchecked return value
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Antonio Quartulli <ordex@autistici.org>
Diffstat (limited to 'net/batman-adv/debugfs.c')
-rw-r--r-- | net/batman-adv/debugfs.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/net/batman-adv/debugfs.c b/net/batman-adv/debugfs.c index 391d4fb2026f..bd032bc4e262 100644 --- a/net/batman-adv/debugfs.c +++ b/net/batman-adv/debugfs.c | |||
@@ -99,15 +99,17 @@ int batadv_debug_log(struct batadv_priv *bat_priv, const char *fmt, ...) | |||
99 | 99 | ||
100 | static int batadv_log_open(struct inode *inode, struct file *file) | 100 | static int batadv_log_open(struct inode *inode, struct file *file) |
101 | { | 101 | { |
102 | if (!try_module_get(THIS_MODULE)) | ||
103 | return -EBUSY; | ||
104 | |||
102 | nonseekable_open(inode, file); | 105 | nonseekable_open(inode, file); |
103 | file->private_data = inode->i_private; | 106 | file->private_data = inode->i_private; |
104 | batadv_inc_module_count(); | ||
105 | return 0; | 107 | return 0; |
106 | } | 108 | } |
107 | 109 | ||
108 | static int batadv_log_release(struct inode *inode, struct file *file) | 110 | static int batadv_log_release(struct inode *inode, struct file *file) |
109 | { | 111 | { |
110 | batadv_dec_module_count(); | 112 | module_put(THIS_MODULE); |
111 | return 0; | 113 | return 0; |
112 | } | 114 | } |
113 | 115 | ||