diff options
author | Julia Lawall <julia@diku.dk> | 2010-08-16 02:26:57 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-08-18 17:26:31 -0400 |
commit | b3d18f15092a7db2f229cd7bc69fc40eac0774f4 (patch) | |
tree | 7bc284b769cc05e172552e400d4b52942a0fa6d9 /net/ax25 | |
parent | 636b8116d4e116eca1ac978f546b16fadfc15a6c (diff) |
net/ax25: Use available error codes
Error codes are stored in err, but the return value is always 0. Return
err instead.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
local idexpression x;
constant C;
@@
if (...) { ...
x = -C
... when != x
(
return <+...x...+>;
|
return NULL;
|
return;
|
* return ...;
)
}
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ax25')
-rw-r--r-- | net/ax25/ax25_route.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/ax25/ax25_route.c b/net/ax25/ax25_route.c index 7805945a5fd6..a1690845dc6e 100644 --- a/net/ax25/ax25_route.c +++ b/net/ax25/ax25_route.c | |||
@@ -412,7 +412,7 @@ int ax25_rt_autobind(ax25_cb *ax25, ax25_address *addr) | |||
412 | { | 412 | { |
413 | ax25_uid_assoc *user; | 413 | ax25_uid_assoc *user; |
414 | ax25_route *ax25_rt; | 414 | ax25_route *ax25_rt; |
415 | int err; | 415 | int err = 0; |
416 | 416 | ||
417 | if ((ax25_rt = ax25_get_route(addr, NULL)) == NULL) | 417 | if ((ax25_rt = ax25_get_route(addr, NULL)) == NULL) |
418 | return -EHOSTUNREACH; | 418 | return -EHOSTUNREACH; |
@@ -453,7 +453,7 @@ int ax25_rt_autobind(ax25_cb *ax25, ax25_address *addr) | |||
453 | put: | 453 | put: |
454 | ax25_put_route(ax25_rt); | 454 | ax25_put_route(ax25_rt); |
455 | 455 | ||
456 | return 0; | 456 | return err; |
457 | } | 457 | } |
458 | 458 | ||
459 | struct sk_buff *ax25_rt_build_path(struct sk_buff *skb, ax25_address *src, | 459 | struct sk_buff *ax25_rt_build_path(struct sk_buff *skb, ax25_address *src, |