diff options
author | Eric Dumazet <dada1@cosmosbay.com> | 2008-01-14 01:29:41 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-01-28 18:02:03 -0500 |
commit | f16f3026db6fa63cbb0f4a37833562aa999c93e5 (patch) | |
tree | 94cf1a39795d04315a1dd2eadbe2d77a453b3844 /net/ax25/ax25_uid.c | |
parent | 6bf1574ee33270e7c0b9d43103e8cedffd9f74db (diff) |
[AX25]: sparse cleanups
net/ax25/ax25_route.c:251:13: warning: context imbalance in
'ax25_rt_seq_start' - wrong count at exit
net/ax25/ax25_route.c:276:13: warning: context imbalance in 'ax25_rt_seq_stop'
- unexpected unlock
net/ax25/ax25_std_timer.c:65:25: warning: expensive signed divide
net/ax25/ax25_uid.c:46:1: warning: symbol 'ax25_uid_list' was not declared.
Should it be static?
net/ax25/ax25_uid.c:146:13: warning: context imbalance in 'ax25_uid_seq_start'
- wrong count at exit
net/ax25/ax25_uid.c:169:13: warning: context imbalance in 'ax25_uid_seq_stop'
- unexpected unlock
net/ax25/af_ax25.c:573:28: warning: expensive signed divide
net/ax25/af_ax25.c:1865:13: warning: context imbalance in 'ax25_info_start' -
wrong count at exit
net/ax25/af_ax25.c:1888:13: warning: context imbalance in 'ax25_info_stop' -
unexpected unlock
net/ax25/ax25_ds_timer.c:133:25: warning: expensive signed divide
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ax25/ax25_uid.c')
-rw-r--r-- | net/ax25/ax25_uid.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/net/ax25/ax25_uid.c b/net/ax25/ax25_uid.c index ce0b13d44385..5f4eb73fb9d3 100644 --- a/net/ax25/ax25_uid.c +++ b/net/ax25/ax25_uid.c | |||
@@ -43,10 +43,10 @@ | |||
43 | * Callsign/UID mapper. This is in kernel space for security on multi-amateur machines. | 43 | * Callsign/UID mapper. This is in kernel space for security on multi-amateur machines. |
44 | */ | 44 | */ |
45 | 45 | ||
46 | HLIST_HEAD(ax25_uid_list); | 46 | static HLIST_HEAD(ax25_uid_list); |
47 | static DEFINE_RWLOCK(ax25_uid_lock); | 47 | static DEFINE_RWLOCK(ax25_uid_lock); |
48 | 48 | ||
49 | int ax25_uid_policy = 0; | 49 | int ax25_uid_policy; |
50 | 50 | ||
51 | EXPORT_SYMBOL(ax25_uid_policy); | 51 | EXPORT_SYMBOL(ax25_uid_policy); |
52 | 52 | ||
@@ -144,6 +144,7 @@ int ax25_uid_ioctl(int cmd, struct sockaddr_ax25 *sax) | |||
144 | #ifdef CONFIG_PROC_FS | 144 | #ifdef CONFIG_PROC_FS |
145 | 145 | ||
146 | static void *ax25_uid_seq_start(struct seq_file *seq, loff_t *pos) | 146 | static void *ax25_uid_seq_start(struct seq_file *seq, loff_t *pos) |
147 | __acquires(ax25_uid_lock) | ||
147 | { | 148 | { |
148 | struct ax25_uid_assoc *pt; | 149 | struct ax25_uid_assoc *pt; |
149 | struct hlist_node *node; | 150 | struct hlist_node *node; |
@@ -167,6 +168,7 @@ static void *ax25_uid_seq_next(struct seq_file *seq, void *v, loff_t *pos) | |||
167 | } | 168 | } |
168 | 169 | ||
169 | static void ax25_uid_seq_stop(struct seq_file *seq, void *v) | 170 | static void ax25_uid_seq_stop(struct seq_file *seq, void *v) |
171 | __releases(ax25_uid_lock) | ||
170 | { | 172 | { |
171 | read_unlock(&ax25_uid_lock); | 173 | read_unlock(&ax25_uid_lock); |
172 | } | 174 | } |