diff options
author | Eric Dumazet <dada1@cosmosbay.com> | 2008-01-14 01:29:41 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-01-28 18:02:03 -0500 |
commit | f16f3026db6fa63cbb0f4a37833562aa999c93e5 (patch) | |
tree | 94cf1a39795d04315a1dd2eadbe2d77a453b3844 /net/ax25/ax25_std_timer.c | |
parent | 6bf1574ee33270e7c0b9d43103e8cedffd9f74db (diff) |
[AX25]: sparse cleanups
net/ax25/ax25_route.c:251:13: warning: context imbalance in
'ax25_rt_seq_start' - wrong count at exit
net/ax25/ax25_route.c:276:13: warning: context imbalance in 'ax25_rt_seq_stop'
- unexpected unlock
net/ax25/ax25_std_timer.c:65:25: warning: expensive signed divide
net/ax25/ax25_uid.c:46:1: warning: symbol 'ax25_uid_list' was not declared.
Should it be static?
net/ax25/ax25_uid.c:146:13: warning: context imbalance in 'ax25_uid_seq_start'
- wrong count at exit
net/ax25/ax25_uid.c:169:13: warning: context imbalance in 'ax25_uid_seq_stop'
- unexpected unlock
net/ax25/af_ax25.c:573:28: warning: expensive signed divide
net/ax25/af_ax25.c:1865:13: warning: context imbalance in 'ax25_info_start' -
wrong count at exit
net/ax25/af_ax25.c:1888:13: warning: context imbalance in 'ax25_info_stop' -
unexpected unlock
net/ax25/ax25_ds_timer.c:133:25: warning: expensive signed divide
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ax25/ax25_std_timer.c')
-rw-r--r-- | net/ax25/ax25_std_timer.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/ax25/ax25_std_timer.c b/net/ax25/ax25_std_timer.c index f2f6918ac9bb..96e4b9273250 100644 --- a/net/ax25/ax25_std_timer.c +++ b/net/ax25/ax25_std_timer.c | |||
@@ -32,7 +32,7 @@ | |||
32 | 32 | ||
33 | void ax25_std_heartbeat_expiry(ax25_cb *ax25) | 33 | void ax25_std_heartbeat_expiry(ax25_cb *ax25) |
34 | { | 34 | { |
35 | struct sock *sk=ax25->sk; | 35 | struct sock *sk = ax25->sk; |
36 | 36 | ||
37 | if (sk) | 37 | if (sk) |
38 | bh_lock_sock(sk); | 38 | bh_lock_sock(sk); |
@@ -62,7 +62,7 @@ void ax25_std_heartbeat_expiry(ax25_cb *ax25) | |||
62 | */ | 62 | */ |
63 | if (sk != NULL) { | 63 | if (sk != NULL) { |
64 | if (atomic_read(&sk->sk_rmem_alloc) < | 64 | if (atomic_read(&sk->sk_rmem_alloc) < |
65 | (sk->sk_rcvbuf / 2) && | 65 | (sk->sk_rcvbuf >> 1) && |
66 | (ax25->condition & AX25_COND_OWN_RX_BUSY)) { | 66 | (ax25->condition & AX25_COND_OWN_RX_BUSY)) { |
67 | ax25->condition &= ~AX25_COND_OWN_RX_BUSY; | 67 | ax25->condition &= ~AX25_COND_OWN_RX_BUSY; |
68 | ax25->condition &= ~AX25_COND_ACK_PENDING; | 68 | ax25->condition &= ~AX25_COND_ACK_PENDING; |