diff options
author | Joe Perches <joe@perches.com> | 2010-01-26 06:40:12 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-01-27 00:16:01 -0500 |
commit | d81219db6add0a176c37d6fe4e1c050778de9d2f (patch) | |
tree | f4b1d7d55a69db10214d98fd4a2c644121cef3be /net/atm | |
parent | f1e100491e0e696b19f37f2b0cf728a5f2bc56e7 (diff) |
net/atm/pppoatm.c: checkpatch cleanups
Move embedded assigns out of tests
Move trailing statements to new lines
Move labels to column 1
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/atm')
-rw-r--r-- | net/atm/pppoatm.c | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/net/atm/pppoatm.c b/net/atm/pppoatm.c index 62db6d71dbab..400839273c67 100644 --- a/net/atm/pppoatm.c +++ b/net/atm/pppoatm.c | |||
@@ -176,7 +176,8 @@ static void pppoatm_push(struct atm_vcc *atmvcc, struct sk_buff *skb) | |||
176 | } | 176 | } |
177 | ppp_input(&pvcc->chan, skb); | 177 | ppp_input(&pvcc->chan, skb); |
178 | return; | 178 | return; |
179 | error: | 179 | |
180 | error: | ||
180 | kfree_skb(skb); | 181 | kfree_skb(skb); |
181 | ppp_input_error(&pvcc->chan, 0); | 182 | ppp_input_error(&pvcc->chan, 0); |
182 | } | 183 | } |
@@ -209,7 +210,8 @@ static int pppoatm_send(struct ppp_channel *chan, struct sk_buff *skb) | |||
209 | goto nospace; | 210 | goto nospace; |
210 | } | 211 | } |
211 | kfree_skb(skb); | 212 | kfree_skb(skb); |
212 | if ((skb = n) == NULL) | 213 | skb = n; |
214 | if (skb == NULL) | ||
213 | return DROP_PACKET; | 215 | return DROP_PACKET; |
214 | } else if (!atm_may_send(pvcc->atmvcc, skb->truesize)) | 216 | } else if (!atm_may_send(pvcc->atmvcc, skb->truesize)) |
215 | goto nospace; | 217 | goto nospace; |
@@ -231,7 +233,7 @@ static int pppoatm_send(struct ppp_channel *chan, struct sk_buff *skb) | |||
231 | skb, ATM_SKB(skb)->vcc, ATM_SKB(skb)->vcc->dev); | 233 | skb, ATM_SKB(skb)->vcc, ATM_SKB(skb)->vcc->dev); |
232 | return ATM_SKB(skb)->vcc->send(ATM_SKB(skb)->vcc, skb) | 234 | return ATM_SKB(skb)->vcc->send(ATM_SKB(skb)->vcc, skb) |
233 | ? DROP_PACKET : 1; | 235 | ? DROP_PACKET : 1; |
234 | nospace: | 236 | nospace: |
235 | /* | 237 | /* |
236 | * We don't have space to send this SKB now, but we might have | 238 | * We don't have space to send this SKB now, but we might have |
237 | * already applied SC_COMP_PROT compression, so may need to undo | 239 | * already applied SC_COMP_PROT compression, so may need to undo |
@@ -290,7 +292,8 @@ static int pppoatm_assign_vcc(struct atm_vcc *atmvcc, void __user *arg) | |||
290 | (be.encaps == e_vc ? 0 : LLC_LEN); | 292 | (be.encaps == e_vc ? 0 : LLC_LEN); |
291 | pvcc->wakeup_tasklet = tasklet_proto; | 293 | pvcc->wakeup_tasklet = tasklet_proto; |
292 | pvcc->wakeup_tasklet.data = (unsigned long) &pvcc->chan; | 294 | pvcc->wakeup_tasklet.data = (unsigned long) &pvcc->chan; |
293 | if ((err = ppp_register_channel(&pvcc->chan)) != 0) { | 295 | err = ppp_register_channel(&pvcc->chan); |
296 | if (err != 0) { | ||
294 | kfree(pvcc); | 297 | kfree(pvcc); |
295 | return err; | 298 | return err; |
296 | } | 299 | } |