diff options
author | Thiago Farina <tfransosi@gmail.com> | 2010-12-04 10:22:46 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-12-08 12:56:28 -0500 |
commit | 01b0c5cfb23f19837650aa53495ace6d0fd7d3f8 (patch) | |
tree | 34a845dade8b89eacbeb84e60b4d6a93fe4ff65b /net/9p/protocol.c | |
parent | aa9421041128abb4d269ee1dc502ff65fb3b7d69 (diff) |
net/9p/protocol.c: Remove duplicated macros.
Use the macros already provided by kernel.h file.
Signed-off-by: Thiago Farina <tfransosi@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/9p/protocol.c')
-rw-r--r-- | net/9p/protocol.c | 33 |
1 files changed, 9 insertions, 24 deletions
diff --git a/net/9p/protocol.c b/net/9p/protocol.c index 45c15f491401..798beac7f100 100644 --- a/net/9p/protocol.c +++ b/net/9p/protocol.c | |||
@@ -27,31 +27,16 @@ | |||
27 | 27 | ||
28 | #include <linux/module.h> | 28 | #include <linux/module.h> |
29 | #include <linux/errno.h> | 29 | #include <linux/errno.h> |
30 | #include <linux/kernel.h> | ||
30 | #include <linux/uaccess.h> | 31 | #include <linux/uaccess.h> |
31 | #include <linux/slab.h> | 32 | #include <linux/slab.h> |
32 | #include <linux/sched.h> | 33 | #include <linux/sched.h> |
34 | #include <linux/stddef.h> | ||
33 | #include <linux/types.h> | 35 | #include <linux/types.h> |
34 | #include <net/9p/9p.h> | 36 | #include <net/9p/9p.h> |
35 | #include <net/9p/client.h> | 37 | #include <net/9p/client.h> |
36 | #include "protocol.h" | 38 | #include "protocol.h" |
37 | 39 | ||
38 | #ifndef MIN | ||
39 | #define MIN(a, b) (((a) < (b)) ? (a) : (b)) | ||
40 | #endif | ||
41 | |||
42 | #ifndef MAX | ||
43 | #define MAX(a, b) (((a) > (b)) ? (a) : (b)) | ||
44 | #endif | ||
45 | |||
46 | #ifndef offset_of | ||
47 | #define offset_of(type, memb) \ | ||
48 | ((unsigned long)(&((type *)0)->memb)) | ||
49 | #endif | ||
50 | #ifndef container_of | ||
51 | #define container_of(obj, type, memb) \ | ||
52 | ((type *)(((char *)obj) - offset_of(type, memb))) | ||
53 | #endif | ||
54 | |||
55 | static int | 40 | static int |
56 | p9pdu_writef(struct p9_fcall *pdu, int proto_version, const char *fmt, ...); | 41 | p9pdu_writef(struct p9_fcall *pdu, int proto_version, const char *fmt, ...); |
57 | 42 | ||
@@ -104,7 +89,7 @@ EXPORT_SYMBOL(p9stat_free); | |||
104 | 89 | ||
105 | static size_t pdu_read(struct p9_fcall *pdu, void *data, size_t size) | 90 | static size_t pdu_read(struct p9_fcall *pdu, void *data, size_t size) |
106 | { | 91 | { |
107 | size_t len = MIN(pdu->size - pdu->offset, size); | 92 | size_t len = min(pdu->size - pdu->offset, size); |
108 | memcpy(data, &pdu->sdata[pdu->offset], len); | 93 | memcpy(data, &pdu->sdata[pdu->offset], len); |
109 | pdu->offset += len; | 94 | pdu->offset += len; |
110 | return size - len; | 95 | return size - len; |
@@ -112,7 +97,7 @@ static size_t pdu_read(struct p9_fcall *pdu, void *data, size_t size) | |||
112 | 97 | ||
113 | static size_t pdu_write(struct p9_fcall *pdu, const void *data, size_t size) | 98 | static size_t pdu_write(struct p9_fcall *pdu, const void *data, size_t size) |
114 | { | 99 | { |
115 | size_t len = MIN(pdu->capacity - pdu->size, size); | 100 | size_t len = min(pdu->capacity - pdu->size, size); |
116 | memcpy(&pdu->sdata[pdu->size], data, len); | 101 | memcpy(&pdu->sdata[pdu->size], data, len); |
117 | pdu->size += len; | 102 | pdu->size += len; |
118 | return size - len; | 103 | return size - len; |
@@ -121,7 +106,7 @@ static size_t pdu_write(struct p9_fcall *pdu, const void *data, size_t size) | |||
121 | static size_t | 106 | static size_t |
122 | pdu_write_u(struct p9_fcall *pdu, const char __user *udata, size_t size) | 107 | pdu_write_u(struct p9_fcall *pdu, const char __user *udata, size_t size) |
123 | { | 108 | { |
124 | size_t len = MIN(pdu->capacity - pdu->size, size); | 109 | size_t len = min(pdu->capacity - pdu->size, size); |
125 | if (copy_from_user(&pdu->sdata[pdu->size], udata, len)) | 110 | if (copy_from_user(&pdu->sdata[pdu->size], udata, len)) |
126 | len = 0; | 111 | len = 0; |
127 | 112 | ||
@@ -201,7 +186,7 @@ p9pdu_vreadf(struct p9_fcall *pdu, int proto_version, const char *fmt, | |||
201 | if (errcode) | 186 | if (errcode) |
202 | break; | 187 | break; |
203 | 188 | ||
204 | size = MAX(len, 0); | 189 | size = max_t(int16_t, len, 0); |
205 | 190 | ||
206 | *sptr = kmalloc(size + 1, GFP_KERNEL); | 191 | *sptr = kmalloc(size + 1, GFP_KERNEL); |
207 | if (*sptr == NULL) { | 192 | if (*sptr == NULL) { |
@@ -256,8 +241,8 @@ p9pdu_vreadf(struct p9_fcall *pdu, int proto_version, const char *fmt, | |||
256 | p9pdu_readf(pdu, proto_version, "d", count); | 241 | p9pdu_readf(pdu, proto_version, "d", count); |
257 | if (!errcode) { | 242 | if (!errcode) { |
258 | *count = | 243 | *count = |
259 | MIN(*count, | 244 | min_t(int32_t, *count, |
260 | pdu->size - pdu->offset); | 245 | pdu->size - pdu->offset); |
261 | *data = &pdu->sdata[pdu->offset]; | 246 | *data = &pdu->sdata[pdu->offset]; |
262 | } | 247 | } |
263 | } | 248 | } |
@@ -421,7 +406,7 @@ p9pdu_vwritef(struct p9_fcall *pdu, int proto_version, const char *fmt, | |||
421 | const char *sptr = va_arg(ap, const char *); | 406 | const char *sptr = va_arg(ap, const char *); |
422 | int16_t len = 0; | 407 | int16_t len = 0; |
423 | if (sptr) | 408 | if (sptr) |
424 | len = MIN(strlen(sptr), USHRT_MAX); | 409 | len = min_t(int16_t, strlen(sptr), USHRT_MAX); |
425 | 410 | ||
426 | errcode = p9pdu_writef(pdu, proto_version, | 411 | errcode = p9pdu_writef(pdu, proto_version, |
427 | "w", len); | 412 | "w", len); |