diff options
author | Herbert Xu <herbert@gondor.apana.org.au> | 2009-01-29 09:19:50 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-01-29 19:33:03 -0500 |
commit | 86911732d3996a9da07914b280621450111bb6da (patch) | |
tree | e787240d5ba869ddf4d0adfc3f9c69e0372e96ef /net/8021q | |
parent | 5d0d9be8ef456afc6c3fb5f8aad06ef19b704b05 (diff) |
gro: Avoid copying headers of unmerged packets
Unfortunately simplicity isn't always the best. The fraginfo
interface turned out to be suboptimal. The problem was quite
obvious. For every packet, we have to copy the headers from
the frags structure into skb->head, even though for 99% of the
packets this part is immediately thrown away after the merge.
LRO didn't have this problem because it directly read the headers
from the frags structure.
This patch attempts to address this by creating an interface
that allows GRO to access the headers in the first frag without
having to copy it. Because all drivers that use frags place the
headers in the first frag this optimisation should be enough.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/8021q')
-rw-r--r-- | net/8021q/vlan_core.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/8021q/vlan_core.c b/net/8021q/vlan_core.c index 2eb057a74654..378fa69d625a 100644 --- a/net/8021q/vlan_core.c +++ b/net/8021q/vlan_core.c | |||
@@ -98,6 +98,8 @@ drop: | |||
98 | int vlan_gro_receive(struct napi_struct *napi, struct vlan_group *grp, | 98 | int vlan_gro_receive(struct napi_struct *napi, struct vlan_group *grp, |
99 | unsigned int vlan_tci, struct sk_buff *skb) | 99 | unsigned int vlan_tci, struct sk_buff *skb) |
100 | { | 100 | { |
101 | skb_gro_reset_offset(skb); | ||
102 | |||
101 | return napi_skb_finish(vlan_gro_common(napi, grp, vlan_tci, skb), skb); | 103 | return napi_skb_finish(vlan_gro_common(napi, grp, vlan_tci, skb), skb); |
102 | } | 104 | } |
103 | EXPORT_SYMBOL(vlan_gro_receive); | 105 | EXPORT_SYMBOL(vlan_gro_receive); |