aboutsummaryrefslogtreecommitdiffstats
path: root/net/8021q
diff options
context:
space:
mode:
authorEric W. Biederman <ebiederm@xmission.com>2007-09-17 14:56:21 -0400
committerDavid S. Miller <davem@sunset.davemloft.net>2007-10-10 19:49:10 -0400
commit881d966b48b035ab3f3aeaae0f3d3f9b584f45b2 (patch)
treec579d59a4107cbbe9e2b85939bc0d496b815c887 /net/8021q
parentb4b510290b056b86611757ce1175a230f1080f53 (diff)
[NET]: Make the device list and device lookups per namespace.
This patch makes most of the generic device layer network namespace safe. This patch makes dev_base_head a network namespace variable, and then it picks up a few associated variables. The functions: dev_getbyhwaddr dev_getfirsthwbytype dev_get_by_flags dev_get_by_name __dev_get_by_name dev_get_by_index __dev_get_by_index dev_ioctl dev_ethtool dev_load wireless_process_ioctl were modified to take a network namespace argument, and deal with it. vlan_ioctl_set and brioctl_set were modified so their hooks will receive a network namespace argument. So basically anthing in the core of the network stack that was affected to by the change of dev_base was modified to handle multiple network namespaces. The rest of the network stack was simply modified to explicitly use &init_net the initial network namespace. This can be fixed when those components of the network stack are modified to handle multiple network namespaces. For now the ifindex generator is left global. Fundametally ifindex numbers are per namespace, or else we will have corner case problems with migration when we get that far. At the same time there are assumptions in the network stack that the ifindex of a network device won't change. Making the ifindex number global seems a good compromise until the network stack can cope with ifindex changes when you change namespaces, and the like. Signed-off-by: Eric W. Biederman <ebiederm@xmission.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/8021q')
-rw-r--r--net/8021q/vlan.c6
-rw-r--r--net/8021q/vlan_netlink.c3
-rw-r--r--net/8021q/vlanproc.c6
3 files changed, 8 insertions, 7 deletions
diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c
index d0d36fdedbe9..a9ced0a6f4c0 100644
--- a/net/8021q/vlan.c
+++ b/net/8021q/vlan.c
@@ -51,7 +51,7 @@ static char vlan_copyright[] = "Ben Greear <greearb@candelatech.com>";
51static char vlan_buggyright[] = "David S. Miller <davem@redhat.com>"; 51static char vlan_buggyright[] = "David S. Miller <davem@redhat.com>";
52 52
53static int vlan_device_event(struct notifier_block *, unsigned long, void *); 53static int vlan_device_event(struct notifier_block *, unsigned long, void *);
54static int vlan_ioctl_handler(void __user *); 54static int vlan_ioctl_handler(struct net *net, void __user *);
55static int unregister_vlan_dev(struct net_device *, unsigned short ); 55static int unregister_vlan_dev(struct net_device *, unsigned short );
56 56
57static struct notifier_block vlan_notifier_block = { 57static struct notifier_block vlan_notifier_block = {
@@ -697,7 +697,7 @@ out:
697 * o execute requested action or pass command to the device driver 697 * o execute requested action or pass command to the device driver
698 * arg is really a struct vlan_ioctl_args __user *. 698 * arg is really a struct vlan_ioctl_args __user *.
699 */ 699 */
700static int vlan_ioctl_handler(void __user *arg) 700static int vlan_ioctl_handler(struct net *net, void __user *arg)
701{ 701{
702 int err; 702 int err;
703 unsigned short vid = 0; 703 unsigned short vid = 0;
@@ -726,7 +726,7 @@ static int vlan_ioctl_handler(void __user *arg)
726 case GET_VLAN_REALDEV_NAME_CMD: 726 case GET_VLAN_REALDEV_NAME_CMD:
727 case GET_VLAN_VID_CMD: 727 case GET_VLAN_VID_CMD:
728 err = -ENODEV; 728 err = -ENODEV;
729 dev = __dev_get_by_name(args.device1); 729 dev = __dev_get_by_name(&init_net, args.device1);
730 if (!dev) 730 if (!dev)
731 goto out; 731 goto out;
732 732
diff --git a/net/8021q/vlan_netlink.c b/net/8021q/vlan_netlink.c
index 6cdd1e015e2d..0996185e2ed5 100644
--- a/net/8021q/vlan_netlink.c
+++ b/net/8021q/vlan_netlink.c
@@ -11,6 +11,7 @@
11#include <linux/kernel.h> 11#include <linux/kernel.h>
12#include <linux/netdevice.h> 12#include <linux/netdevice.h>
13#include <linux/if_vlan.h> 13#include <linux/if_vlan.h>
14#include <net/net_namespace.h>
14#include <net/netlink.h> 15#include <net/netlink.h>
15#include <net/rtnetlink.h> 16#include <net/rtnetlink.h>
16#include "vlan.h" 17#include "vlan.h"
@@ -112,7 +113,7 @@ static int vlan_newlink(struct net_device *dev,
112 113
113 if (!tb[IFLA_LINK]) 114 if (!tb[IFLA_LINK])
114 return -EINVAL; 115 return -EINVAL;
115 real_dev = __dev_get_by_index(nla_get_u32(tb[IFLA_LINK])); 116 real_dev = __dev_get_by_index(&init_net, nla_get_u32(tb[IFLA_LINK]));
116 if (!real_dev) 117 if (!real_dev)
117 return -ENODEV; 118 return -ENODEV;
118 119
diff --git a/net/8021q/vlanproc.c b/net/8021q/vlanproc.c
index ac80e6b9ef53..6cefdf8e381a 100644
--- a/net/8021q/vlanproc.c
+++ b/net/8021q/vlanproc.c
@@ -254,7 +254,7 @@ static void *vlan_seq_start(struct seq_file *seq, loff_t *pos)
254 if (*pos == 0) 254 if (*pos == 0)
255 return SEQ_START_TOKEN; 255 return SEQ_START_TOKEN;
256 256
257 for_each_netdev(dev) { 257 for_each_netdev(&init_net, dev) {
258 if (!is_vlan_dev(dev)) 258 if (!is_vlan_dev(dev))
259 continue; 259 continue;
260 260
@@ -273,9 +273,9 @@ static void *vlan_seq_next(struct seq_file *seq, void *v, loff_t *pos)
273 273
274 dev = (struct net_device *)v; 274 dev = (struct net_device *)v;
275 if (v == SEQ_START_TOKEN) 275 if (v == SEQ_START_TOKEN)
276 dev = net_device_entry(&dev_base_head); 276 dev = net_device_entry(&init_net.dev_base_head);
277 277
278 for_each_netdev_continue(dev) { 278 for_each_netdev_continue(&init_net, dev) {
279 if (!is_vlan_dev(dev)) 279 if (!is_vlan_dev(dev))
280 continue; 280 continue;
281 281