diff options
author | Eric Dumazet <dada1@cosmosbay.com> | 2009-05-17 20:35:38 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-05-18 18:15:06 -0400 |
commit | 450c4ea15ecb89567e6a75b89cbb8a598a7efb75 (patch) | |
tree | 5e99e5e58ca2e5e046d47963773ef66857bec46a /net/8021q/vlanproc.c | |
parent | 7004bf252c53da18f6b55103e0c92f777f846806 (diff) |
vlan: use struct netdev_queue counters instead of dev->stats
We can update netdev_queue tx_bytes/tx_packets/tx_dropped counters instead
of dev->stats ones, to reduce number of cache lines dirtied in xmit path.
This fixes a performance problem on SMP when many different cpus take
vlan tx path.
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/8021q/vlanproc.c')
-rw-r--r-- | net/8021q/vlanproc.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/8021q/vlanproc.c b/net/8021q/vlanproc.c index 3628e0a81b40..b55a091a33df 100644 --- a/net/8021q/vlanproc.c +++ b/net/8021q/vlanproc.c | |||
@@ -279,13 +279,14 @@ static int vlandev_seq_show(struct seq_file *seq, void *offset) | |||
279 | { | 279 | { |
280 | struct net_device *vlandev = (struct net_device *) seq->private; | 280 | struct net_device *vlandev = (struct net_device *) seq->private; |
281 | const struct vlan_dev_info *dev_info = vlan_dev_info(vlandev); | 281 | const struct vlan_dev_info *dev_info = vlan_dev_info(vlandev); |
282 | struct net_device_stats *stats = &vlandev->stats; | 282 | const struct net_device_stats *stats; |
283 | static const char fmt[] = "%30s %12lu\n"; | 283 | static const char fmt[] = "%30s %12lu\n"; |
284 | int i; | 284 | int i; |
285 | 285 | ||
286 | if (!is_vlan_dev(vlandev)) | 286 | if (!is_vlan_dev(vlandev)) |
287 | return 0; | 287 | return 0; |
288 | 288 | ||
289 | stats = dev_get_stats(vlandev); | ||
289 | seq_printf(seq, | 290 | seq_printf(seq, |
290 | "%s VID: %d REORDER_HDR: %i dev->priv_flags: %hx\n", | 291 | "%s VID: %d REORDER_HDR: %i dev->priv_flags: %hx\n", |
291 | vlandev->name, dev_info->vlan_id, | 292 | vlandev->name, dev_info->vlan_id, |