diff options
author | Joe Perches <joe@perches.com> | 2007-10-03 20:59:30 -0400 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2007-10-10 19:51:42 -0400 |
commit | 0795af5729b18218767fab27c44b1384f72dc9ad (patch) | |
tree | 67c16df84aa6ec219340b8ea1b5cfb0e8150a216 /net/802/tr.c | |
parent | 95ea36275f3c9a1d3d04c217b4b576c657c4e70e (diff) |
[NET]: Introduce and use print_mac() and DECLARE_MAC_BUF()
This is nicer than the MAC_FMT stuff.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/802/tr.c')
-rw-r--r-- | net/802/tr.c | 28 |
1 files changed, 15 insertions, 13 deletions
diff --git a/net/802/tr.c b/net/802/tr.c index 55c76d77d322..aa3c2e936abc 100644 --- a/net/802/tr.c +++ b/net/802/tr.c | |||
@@ -283,8 +283,10 @@ void tr_source_route(struct sk_buff *skb,struct trh_hdr *trh,struct net_device * | |||
283 | if(entry) | 283 | if(entry) |
284 | { | 284 | { |
285 | #if TR_SR_DEBUG | 285 | #if TR_SR_DEBUG |
286 | printk("source routing for %02X:%02X:%02X:%02X:%02X:%02X\n",trh->daddr[0], | 286 | { |
287 | trh->daddr[1],trh->daddr[2],trh->daddr[3],trh->daddr[4],trh->daddr[5]); | 287 | DECLARE_MAC_BUF(mac); |
288 | printk("source routing for %s\n",print_mac(mac, trh->daddr)); | ||
289 | } | ||
288 | #endif | 290 | #endif |
289 | if(!entry->local_ring && (ntohs(entry->rcf) & TR_RCF_LEN_MASK) >> 8) | 291 | if(!entry->local_ring && (ntohs(entry->rcf) & TR_RCF_LEN_MASK) >> 8) |
290 | { | 292 | { |
@@ -366,10 +368,9 @@ static void tr_add_rif_info(struct trh_hdr *trh, struct net_device *dev) | |||
366 | if(entry==NULL) | 368 | if(entry==NULL) |
367 | { | 369 | { |
368 | #if TR_SR_DEBUG | 370 | #if TR_SR_DEBUG |
369 | printk("adding rif_entry: addr:%02X:%02X:%02X:%02X:%02X:%02X rcf:%04X\n", | 371 | DECLARE_MAC_BUF(mac); |
370 | trh->saddr[0],trh->saddr[1],trh->saddr[2], | 372 | printk("adding rif_entry: addr:%s rcf:%04X\n", |
371 | trh->saddr[3],trh->saddr[4],trh->saddr[5], | 373 | print_mac(mac, trh->saddr), ntohs(trh->rcf)); |
372 | ntohs(trh->rcf)); | ||
373 | #endif | 374 | #endif |
374 | /* | 375 | /* |
375 | * Allocate our new entry. A failure to allocate loses | 376 | * Allocate our new entry. A failure to allocate loses |
@@ -414,10 +415,11 @@ printk("adding rif_entry: addr:%02X:%02X:%02X:%02X:%02X:%02X rcf:%04X\n", | |||
414 | !(trh->rcf & htons(TR_RCF_BROADCAST_MASK))) | 415 | !(trh->rcf & htons(TR_RCF_BROADCAST_MASK))) |
415 | { | 416 | { |
416 | #if TR_SR_DEBUG | 417 | #if TR_SR_DEBUG |
417 | printk("updating rif_entry: addr:%02X:%02X:%02X:%02X:%02X:%02X rcf:%04X\n", | 418 | { |
418 | trh->saddr[0],trh->saddr[1],trh->saddr[2], | 419 | DECLARE_MAC_BUF(mac); |
419 | trh->saddr[3],trh->saddr[4],trh->saddr[5], | 420 | printk("updating rif_entry: addr:%s rcf:%04X\n", |
420 | ntohs(trh->rcf)); | 421 | print_mac(mac, trh->saddr), ntohs(trh->rcf)); |
422 | } | ||
421 | #endif | 423 | #endif |
422 | entry->rcf = trh->rcf & htons((unsigned short)~TR_RCF_BROADCAST_MASK); | 424 | entry->rcf = trh->rcf & htons((unsigned short)~TR_RCF_BROADCAST_MASK); |
423 | memcpy(&(entry->rseg[0]),&(trh->rseg[0]),8*sizeof(unsigned short)); | 425 | memcpy(&(entry->rseg[0]),&(trh->rseg[0]),8*sizeof(unsigned short)); |
@@ -528,6 +530,7 @@ static int rif_seq_show(struct seq_file *seq, void *v) | |||
528 | { | 530 | { |
529 | int j, rcf_len, segment, brdgnmb; | 531 | int j, rcf_len, segment, brdgnmb; |
530 | struct rif_cache *entry = v; | 532 | struct rif_cache *entry = v; |
533 | DECLARE_MAC_BUF(mac); | ||
531 | 534 | ||
532 | if (v == SEQ_START_TOKEN) | 535 | if (v == SEQ_START_TOKEN) |
533 | seq_puts(seq, | 536 | seq_puts(seq, |
@@ -537,10 +540,9 @@ static int rif_seq_show(struct seq_file *seq, void *v) | |||
537 | long ttl = (long) (entry->last_used + sysctl_tr_rif_timeout) | 540 | long ttl = (long) (entry->last_used + sysctl_tr_rif_timeout) |
538 | - (long) jiffies; | 541 | - (long) jiffies; |
539 | 542 | ||
540 | seq_printf(seq, "%s %02X:%02X:%02X:%02X:%02X:%02X %7li ", | 543 | seq_printf(seq, "%s %s %7li ", |
541 | dev?dev->name:"?", | 544 | dev?dev->name:"?", |
542 | entry->addr[0],entry->addr[1],entry->addr[2], | 545 | print_mac(mac, entry->addr), |
543 | entry->addr[3],entry->addr[4],entry->addr[5], | ||
544 | ttl/HZ); | 546 | ttl/HZ); |
545 | 547 | ||
546 | if (entry->local_ring) | 548 | if (entry->local_ring) |