diff options
author | Andi Kleen <ak@linux.intel.com> | 2010-10-06 15:45:00 -0400 |
---|---|---|
committer | Andi Kleen <ak@linux.intel.com> | 2010-10-08 03:32:46 -0400 |
commit | aa50d3a7aa8147b9e14dc9d5972a5d2359db4ef8 (patch) | |
tree | 68fae5060333dcc24c17e9dd00a87bd760d883e9 /mm | |
parent | 6f39ce056ab2ab2d29b2fae4aed61ed0b485972f (diff) |
Encode huge page size for VM_FAULT_HWPOISON errors
This fixes a problem introduced with the hugetlb hwpoison handling
The user space SIGBUS signalling wants to know the size of the hugepage
that caused a HWPOISON fault.
Unfortunately the architecture page fault handlers do not have easy
access to the struct page.
Pass the information out in the fault error code instead.
I added a separate VM_FAULT_HWPOISON_LARGE bit for this case and encode
the hpage index in some free upper bits of the fault code. The small
page hwpoison keeps stays with the VM_FAULT_HWPOISON name to minimize
changes.
Also add code to hugetlb.h to convert that index into a page shift.
Will be used in a further patch.
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: fengguang.wu@intel.com
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Diffstat (limited to 'mm')
-rw-r--r-- | mm/hugetlb.c | 6 | ||||
-rw-r--r-- | mm/memory.c | 3 |
2 files changed, 6 insertions, 3 deletions
diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 67cd03239b75..96991ded82fe 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c | |||
@@ -2589,7 +2589,8 @@ retry: | |||
2589 | * So we need to block hugepage fault by PG_hwpoison bit check. | 2589 | * So we need to block hugepage fault by PG_hwpoison bit check. |
2590 | */ | 2590 | */ |
2591 | if (unlikely(PageHWPoison(page))) { | 2591 | if (unlikely(PageHWPoison(page))) { |
2592 | ret = VM_FAULT_HWPOISON; | 2592 | ret = VM_FAULT_HWPOISON | |
2593 | VM_FAULT_SET_HINDEX(h - hstates); | ||
2593 | goto backout_unlocked; | 2594 | goto backout_unlocked; |
2594 | } | 2595 | } |
2595 | page_dup_rmap(page); | 2596 | page_dup_rmap(page); |
@@ -2656,7 +2657,8 @@ int hugetlb_fault(struct mm_struct *mm, struct vm_area_struct *vma, | |||
2656 | migration_entry_wait(mm, (pmd_t *)ptep, address); | 2657 | migration_entry_wait(mm, (pmd_t *)ptep, address); |
2657 | return 0; | 2658 | return 0; |
2658 | } else if (unlikely(is_hugetlb_entry_hwpoisoned(entry))) | 2659 | } else if (unlikely(is_hugetlb_entry_hwpoisoned(entry))) |
2659 | return VM_FAULT_HWPOISON; | 2660 | return VM_FAULT_HWPOISON_LARGE | |
2661 | VM_FAULT_SET_HINDEX(h - hstates); | ||
2660 | } | 2662 | } |
2661 | 2663 | ||
2662 | ptep = huge_pte_alloc(mm, address, huge_page_size(h)); | 2664 | ptep = huge_pte_alloc(mm, address, huge_page_size(h)); |
diff --git a/mm/memory.c b/mm/memory.c index 0e18b4d649ec..c2d6dd315659 100644 --- a/mm/memory.c +++ b/mm/memory.c | |||
@@ -1450,7 +1450,8 @@ int __get_user_pages(struct task_struct *tsk, struct mm_struct *mm, | |||
1450 | if (ret & VM_FAULT_OOM) | 1450 | if (ret & VM_FAULT_OOM) |
1451 | return i ? i : -ENOMEM; | 1451 | return i ? i : -ENOMEM; |
1452 | if (ret & | 1452 | if (ret & |
1453 | (VM_FAULT_HWPOISON|VM_FAULT_SIGBUS)) | 1453 | (VM_FAULT_HWPOISON|VM_FAULT_HWPOISON_LARGE| |
1454 | VM_FAULT_SIGBUS)) | ||
1454 | return i ? i : -EFAULT; | 1455 | return i ? i : -EFAULT; |
1455 | BUG(); | 1456 | BUG(); |
1456 | } | 1457 | } |