diff options
author | Andi Kleen <ak@suse.de> | 2008-01-30 07:33:18 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2008-01-30 07:33:18 -0500 |
commit | 03252919b79891063cf99145612360efbdf9500b (patch) | |
tree | a80dc0c89448308d75d247446a5a04c84cb708a6 /mm | |
parent | d3432896dae72ee97deb850ad7bbc30329d32c0d (diff) |
x86: print which shared library/executable faulted in segfault etc. messages v3
They now look like:
hal-resmgr[13791]: segfault at 3c rip 2b9c8caec182 rsp 7fff1e825d30 error 4 in libacl.so.1.1.0[2b9c8caea000+6000]
This makes it easier to pinpoint bugs to specific libraries.
And printing the offset into a mapping also always allows to find the
correct fault point in a library even with randomized mappings. Previously
there was no way to actually find the correct code address inside
the randomized mapping.
Relies on earlier patch to shorten the printk formats.
They are often now longer than 80 characters, but I think that's worth it.
[includes fix from Eric Dumazet to check d_path error value]
Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'mm')
-rw-r--r-- | mm/memory.c | 31 |
1 files changed, 31 insertions, 0 deletions
diff --git a/mm/memory.c b/mm/memory.c index 673ebbf499c7..d902d0e25edc 100644 --- a/mm/memory.c +++ b/mm/memory.c | |||
@@ -2754,3 +2754,34 @@ int access_process_vm(struct task_struct *tsk, unsigned long addr, void *buf, in | |||
2754 | 2754 | ||
2755 | return buf - old_buf; | 2755 | return buf - old_buf; |
2756 | } | 2756 | } |
2757 | |||
2758 | /* | ||
2759 | * Print the name of a VMA. | ||
2760 | */ | ||
2761 | void print_vma_addr(char *prefix, unsigned long ip) | ||
2762 | { | ||
2763 | struct mm_struct *mm = current->mm; | ||
2764 | struct vm_area_struct *vma; | ||
2765 | |||
2766 | down_read(&mm->mmap_sem); | ||
2767 | vma = find_vma(mm, ip); | ||
2768 | if (vma && vma->vm_file) { | ||
2769 | struct file *f = vma->vm_file; | ||
2770 | char *buf = (char *)__get_free_page(GFP_KERNEL); | ||
2771 | if (buf) { | ||
2772 | char *p, *s; | ||
2773 | |||
2774 | p = d_path(f->f_dentry, f->f_vfsmnt, buf, PAGE_SIZE); | ||
2775 | if (IS_ERR(p)) | ||
2776 | p = "?"; | ||
2777 | s = strrchr(p, '/'); | ||
2778 | if (s) | ||
2779 | p = s+1; | ||
2780 | printk("%s%s[%lx+%lx]", prefix, p, | ||
2781 | vma->vm_start, | ||
2782 | vma->vm_end - vma->vm_start); | ||
2783 | free_page((unsigned long)buf); | ||
2784 | } | ||
2785 | } | ||
2786 | up_read(¤t->mm->mmap_sem); | ||
2787 | } | ||