aboutsummaryrefslogtreecommitdiffstats
path: root/mm
diff options
context:
space:
mode:
authorJohannes Weiner <hannes@cmpxchg.org>2014-08-06 19:08:16 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2014-08-06 21:01:22 -0400
commit61e02c745721a361ba238e70bfa1c84a4df1a4b7 (patch)
tree955aed6249a0dc68faa09bec44acbd68ffb5fbbe /mm
parent618fde872163e782183ce574c77f1123e2be8887 (diff)
mm: memcontrol: clean up reclaim size variable use in try_charge()
Charge reclaim and OOM currently use the charge batch variable, but batching is already disabled at that point. To simplify the charge logic, the batch variable is reset to the original request size when reclaim is entered, so it's functionally equal, but it's misleading. Switch reclaim/OOM to nr_pages, which is the original request size. Signed-off-by: Johannes Weiner <hannes@cmpxchg.org> Cc: Michal Hocko <mhocko@suse.cz> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm')
-rw-r--r--mm/memcontrol.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index a6a062e409eb..90dc501eaf3f 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -2612,7 +2612,7 @@ retry:
2612 2612
2613 nr_reclaimed = mem_cgroup_reclaim(mem_over_limit, gfp_mask, flags); 2613 nr_reclaimed = mem_cgroup_reclaim(mem_over_limit, gfp_mask, flags);
2614 2614
2615 if (mem_cgroup_margin(mem_over_limit) >= batch) 2615 if (mem_cgroup_margin(mem_over_limit) >= nr_pages)
2616 goto retry; 2616 goto retry;
2617 2617
2618 if (gfp_mask & __GFP_NORETRY) 2618 if (gfp_mask & __GFP_NORETRY)
@@ -2626,7 +2626,7 @@ retry:
2626 * unlikely to succeed so close to the limit, and we fall back 2626 * unlikely to succeed so close to the limit, and we fall back
2627 * to regular pages anyway in case of failure. 2627 * to regular pages anyway in case of failure.
2628 */ 2628 */
2629 if (nr_reclaimed && batch <= (1 << PAGE_ALLOC_COSTLY_ORDER)) 2629 if (nr_reclaimed && nr_pages <= (1 << PAGE_ALLOC_COSTLY_ORDER))
2630 goto retry; 2630 goto retry;
2631 /* 2631 /*
2632 * At task move, charge accounts can be doubly counted. So, it's 2632 * At task move, charge accounts can be doubly counted. So, it's
@@ -2644,7 +2644,7 @@ retry:
2644 if (fatal_signal_pending(current)) 2644 if (fatal_signal_pending(current))
2645 goto bypass; 2645 goto bypass;
2646 2646
2647 mem_cgroup_oom(mem_over_limit, gfp_mask, get_order(batch)); 2647 mem_cgroup_oom(mem_over_limit, gfp_mask, get_order(nr_pages));
2648nomem: 2648nomem:
2649 if (!(gfp_mask & __GFP_NOFAIL)) 2649 if (!(gfp_mask & __GFP_NOFAIL))
2650 return -ENOMEM; 2650 return -ENOMEM;