aboutsummaryrefslogtreecommitdiffstats
path: root/mm
diff options
context:
space:
mode:
authorChristoph Lameter <cl@linux-foundation.org>2009-06-16 18:32:15 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2009-06-16 22:47:35 -0400
commit62bc62a873116805774ffd37d7f86aa4faa832b1 (patch)
tree7f3f5b94b2d484a13ca27b8d3f6f54cfe126d7c0 /mm
parent974709bdb2a34db378fc84140220f363f558d0d6 (diff)
page allocator: use a pre-calculated value instead of num_online_nodes() in fast paths
num_online_nodes() is called in a number of places but most often by the page allocator when deciding whether the zonelist needs to be filtered based on cpusets or the zonelist cache. This is actually a heavy function and touches a number of cache lines. This patch stores the number of online nodes at boot time and updates the value when nodes get onlined and offlined. The value is then used in a number of important paths in place of num_online_nodes(). [rientjes@google.com: do not override definition of node_set_online() with macro] Signed-off-by: Christoph Lameter <cl@linux-foundation.org> Signed-off-by: Mel Gorman <mel@csn.ul.ie> Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> Cc: Pekka Enberg <penberg@cs.helsinki.fi> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Nick Piggin <nickpiggin@yahoo.com.au> Cc: Dave Hansen <dave@linux.vnet.ibm.com> Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com> Signed-off-by: David Rientjes <rientjes@google.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm')
-rw-r--r--mm/hugetlb.c4
-rw-r--r--mm/page_alloc.c10
-rw-r--r--mm/slub.c2
3 files changed, 9 insertions, 7 deletions
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 2f8241f300f5..7b9b6015b2ec 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -875,7 +875,7 @@ static void return_unused_surplus_pages(struct hstate *h,
875 * can no longer free unreserved surplus pages. This occurs when 875 * can no longer free unreserved surplus pages. This occurs when
876 * the nodes with surplus pages have no free pages. 876 * the nodes with surplus pages have no free pages.
877 */ 877 */
878 unsigned long remaining_iterations = num_online_nodes(); 878 unsigned long remaining_iterations = nr_online_nodes;
879 879
880 /* Uncommit the reservation */ 880 /* Uncommit the reservation */
881 h->resv_huge_pages -= unused_resv_pages; 881 h->resv_huge_pages -= unused_resv_pages;
@@ -904,7 +904,7 @@ static void return_unused_surplus_pages(struct hstate *h,
904 h->surplus_huge_pages--; 904 h->surplus_huge_pages--;
905 h->surplus_huge_pages_node[nid]--; 905 h->surplus_huge_pages_node[nid]--;
906 nr_pages--; 906 nr_pages--;
907 remaining_iterations = num_online_nodes(); 907 remaining_iterations = nr_online_nodes;
908 } 908 }
909 } 909 }
910} 910}
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index e60e41474332..0c9f406e3c44 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -161,7 +161,9 @@ static unsigned long __meminitdata dma_reserve;
161 161
162#if MAX_NUMNODES > 1 162#if MAX_NUMNODES > 1
163int nr_node_ids __read_mostly = MAX_NUMNODES; 163int nr_node_ids __read_mostly = MAX_NUMNODES;
164int nr_online_nodes __read_mostly = 1;
164EXPORT_SYMBOL(nr_node_ids); 165EXPORT_SYMBOL(nr_node_ids);
166EXPORT_SYMBOL(nr_online_nodes);
165#endif 167#endif
166 168
167int page_group_by_mobility_disabled __read_mostly; 169int page_group_by_mobility_disabled __read_mostly;
@@ -1466,7 +1468,7 @@ this_zone_full:
1466 if (NUMA_BUILD) 1468 if (NUMA_BUILD)
1467 zlc_mark_zone_full(zonelist, z); 1469 zlc_mark_zone_full(zonelist, z);
1468try_next_zone: 1470try_next_zone:
1469 if (NUMA_BUILD && !did_zlc_setup && num_online_nodes() > 1) { 1471 if (NUMA_BUILD && !did_zlc_setup && nr_online_nodes > 1) {
1470 /* 1472 /*
1471 * we do zlc_setup after the first zone is tried but only 1473 * we do zlc_setup after the first zone is tried but only
1472 * if there are multiple nodes make it worthwhile 1474 * if there are multiple nodes make it worthwhile
@@ -2265,7 +2267,7 @@ int numa_zonelist_order_handler(ctl_table *table, int write,
2265} 2267}
2266 2268
2267 2269
2268#define MAX_NODE_LOAD (num_online_nodes()) 2270#define MAX_NODE_LOAD (nr_online_nodes)
2269static int node_load[MAX_NUMNODES]; 2271static int node_load[MAX_NUMNODES];
2270 2272
2271/** 2273/**
@@ -2474,7 +2476,7 @@ static void build_zonelists(pg_data_t *pgdat)
2474 2476
2475 /* NUMA-aware ordering of nodes */ 2477 /* NUMA-aware ordering of nodes */
2476 local_node = pgdat->node_id; 2478 local_node = pgdat->node_id;
2477 load = num_online_nodes(); 2479 load = nr_online_nodes;
2478 prev_node = local_node; 2480 prev_node = local_node;
2479 nodes_clear(used_mask); 2481 nodes_clear(used_mask);
2480 2482
@@ -2625,7 +2627,7 @@ void build_all_zonelists(void)
2625 2627
2626 printk("Built %i zonelists in %s order, mobility grouping %s. " 2628 printk("Built %i zonelists in %s order, mobility grouping %s. "
2627 "Total pages: %ld\n", 2629 "Total pages: %ld\n",
2628 num_online_nodes(), 2630 nr_online_nodes,
2629 zonelist_order_name[current_zonelist_order], 2631 zonelist_order_name[current_zonelist_order],
2630 page_group_by_mobility_disabled ? "off" : "on", 2632 page_group_by_mobility_disabled ? "off" : "on",
2631 vm_total_pages); 2633 vm_total_pages);
diff --git a/mm/slub.c b/mm/slub.c
index 30354bfeb43d..1c950775d6be 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -3737,7 +3737,7 @@ static int list_locations(struct kmem_cache *s, char *buf,
3737 to_cpumask(l->cpus)); 3737 to_cpumask(l->cpus));
3738 } 3738 }
3739 3739
3740 if (num_online_nodes() > 1 && !nodes_empty(l->nodes) && 3740 if (nr_online_nodes > 1 && !nodes_empty(l->nodes) &&
3741 len < PAGE_SIZE - 60) { 3741 len < PAGE_SIZE - 60) {
3742 len += sprintf(buf + len, " nodes="); 3742 len += sprintf(buf + len, " nodes=");
3743 len += nodelist_scnprintf(buf + len, PAGE_SIZE - len - 50, 3743 len += nodelist_scnprintf(buf + len, PAGE_SIZE - len - 50,