diff options
author | Nick Piggin <npiggin@suse.de> | 2006-09-26 02:31:30 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-09-26 11:48:48 -0400 |
commit | 4a3ede107e422a0c53d28024b0aa902ca22a8768 (patch) | |
tree | 39f687cc0470cea45ed1387ebc16fee7d6066485 /mm | |
parent | 50ec3bbffbe8a96347c54832d48110a5bc9e9ff8 (diff) |
[PATCH] oom: handle oom_disable exiting
Having the oomkilladj == OOM_DISABLE check before the releasing check means
that oomkilladj == OOM_DISABLE tasks exiting will not stop the OOM killer.
Moving the test down will give the desired behaviour. Also: it will allow
them to "OOM-kill" themselves if they are exiting. As per the previous patch,
this is required to prevent OOM killer deadlocks (and they don't actually get
killed, because they're already exiting -- they're simply allowed access to
memory reserves).
Signed-off-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'mm')
-rw-r--r-- | mm/oom_kill.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/mm/oom_kill.c b/mm/oom_kill.c index 0131bae2a16d..55a05f1ef76d 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c | |||
@@ -204,8 +204,6 @@ static struct task_struct *select_bad_process(unsigned long *ppoints) | |||
204 | /* skip the init task with pid == 1 */ | 204 | /* skip the init task with pid == 1 */ |
205 | if (p->pid == 1) | 205 | if (p->pid == 1) |
206 | continue; | 206 | continue; |
207 | if (p->oomkilladj == OOM_DISABLE) | ||
208 | continue; | ||
209 | 207 | ||
210 | /* | 208 | /* |
211 | * This is in the process of releasing memory so wait for it | 209 | * This is in the process of releasing memory so wait for it |
@@ -230,6 +228,8 @@ static struct task_struct *select_bad_process(unsigned long *ppoints) | |||
230 | } | 228 | } |
231 | return ERR_PTR(-1UL); | 229 | return ERR_PTR(-1UL); |
232 | } | 230 | } |
231 | if (p->oomkilladj == OOM_DISABLE) | ||
232 | continue; | ||
233 | if (p->flags & PF_SWAPOFF) | 233 | if (p->flags & PF_SWAPOFF) |
234 | return p; | 234 | return p; |
235 | 235 | ||