aboutsummaryrefslogtreecommitdiffstats
path: root/mm
diff options
context:
space:
mode:
authorHugh Dickins <hugh@veritas.com>2005-10-29 21:16:02 -0400
committerLinus Torvalds <torvalds@g5.osdl.org>2005-10-30 00:40:37 -0400
commit4d6ddfa9242bc3d27fb0f7248f6fdee0299c731f (patch)
treeda5b753df64e7163a35487005e50a3b90b0b0b9b /mm
parent15a23ffa2fc91cebdac44d4aee994f59d5c28dc0 (diff)
[PATCH] mm: tlb_is_full_mm was obscure
tlb_is_full_mm? What does that mean? The TLB is full? No, it means that the mm's last user has gone and the whole mm is being torn down. And it's an inline function because sparc64 uses a different (slightly better) "tlb_frozen" name for the flag others call "fullmm". And now the ptep_get_and_clear_full macro used in zap_pte_range refers directly to tlb->fullmm, which would be wrong for sparc64. Rather than correct that, I'd prefer to scrap tlb_is_full_mm altogether, and change sparc64 to just use the same poor name as everyone else - is that okay? Signed-off-by: Hugh Dickins <hugh@veritas.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'mm')
-rw-r--r--mm/memory.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/mm/memory.c b/mm/memory.c
index eaf79031f573..585bb4e0b97f 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -249,7 +249,7 @@ void free_pgd_range(struct mmu_gather **tlb,
249 free_pud_range(*tlb, pgd, addr, next, floor, ceiling); 249 free_pud_range(*tlb, pgd, addr, next, floor, ceiling);
250 } while (pgd++, addr = next, addr != end); 250 } while (pgd++, addr = next, addr != end);
251 251
252 if (!tlb_is_full_mm(*tlb)) 252 if (!(*tlb)->fullmm)
253 flush_tlb_pgtables((*tlb)->mm, start, end); 253 flush_tlb_pgtables((*tlb)->mm, start, end);
254} 254}
255 255
@@ -698,7 +698,7 @@ unsigned long unmap_vmas(struct mmu_gather **tlbp, struct mm_struct *mm,
698 int tlb_start_valid = 0; 698 int tlb_start_valid = 0;
699 unsigned long start = start_addr; 699 unsigned long start = start_addr;
700 spinlock_t *i_mmap_lock = details? details->i_mmap_lock: NULL; 700 spinlock_t *i_mmap_lock = details? details->i_mmap_lock: NULL;
701 int fullmm = tlb_is_full_mm(*tlbp); 701 int fullmm = (*tlbp)->fullmm;
702 702
703 for ( ; vma && vma->vm_start < end_addr; vma = vma->vm_next) { 703 for ( ; vma && vma->vm_start < end_addr; vma = vma->vm_next) {
704 unsigned long end; 704 unsigned long end;