diff options
author | Hugh Dickins <hugh@veritas.com> | 2005-11-22 00:32:14 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2005-11-22 12:13:42 -0500 |
commit | 664beed0190fae687ac51295694004902ddeb18e (patch) | |
tree | 89a7c8d9d541fb678c567834cb758fc88b375d47 /mm | |
parent | 1cdca61bf8537043edde8ef784ce1a1351361dac (diff) |
[PATCH] unpaged: unifdefed PageCompound
It looks like snd_xxx is not the only nopage to be using PageReserved as a way
of holding a high-order page together: which no longer works, but is masked by
our failure to free from VM_RESERVED areas. We cannot fix that bug without
first substituting another way to hold the high-order page together, while
farming out the 0-order pages from within it.
That's just what PageCompound is designed for, but it's been kept under
CONFIG_HUGETLB_PAGE. Remove the #ifdefs: which saves some space (out- of-line
put_page), doesn't slow down what most needs to be fast (already using
hugetlb), and unifies the way we handle high-order pages.
Signed-off-by: Hugh Dickins <hugh@veritas.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'mm')
-rw-r--r-- | mm/page_alloc.c | 5 | ||||
-rw-r--r-- | mm/swap.c | 3 |
2 files changed, 0 insertions, 8 deletions
diff --git a/mm/page_alloc.c b/mm/page_alloc.c index bd4de592dc23..23b84c4e1a57 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c | |||
@@ -148,10 +148,6 @@ static void bad_page(const char *function, struct page *page) | |||
148 | add_taint(TAINT_BAD_PAGE); | 148 | add_taint(TAINT_BAD_PAGE); |
149 | } | 149 | } |
150 | 150 | ||
151 | #ifndef CONFIG_HUGETLB_PAGE | ||
152 | #define prep_compound_page(page, order) do { } while (0) | ||
153 | #define destroy_compound_page(page, order) do { } while (0) | ||
154 | #else | ||
155 | /* | 151 | /* |
156 | * Higher-order pages are called "compound pages". They are structured thusly: | 152 | * Higher-order pages are called "compound pages". They are structured thusly: |
157 | * | 153 | * |
@@ -205,7 +201,6 @@ static void destroy_compound_page(struct page *page, unsigned long order) | |||
205 | ClearPageCompound(p); | 201 | ClearPageCompound(p); |
206 | } | 202 | } |
207 | } | 203 | } |
208 | #endif /* CONFIG_HUGETLB_PAGE */ | ||
209 | 204 | ||
210 | /* | 205 | /* |
211 | * function for dealing with page's order in buddy system. | 206 | * function for dealing with page's order in buddy system. |
@@ -34,8 +34,6 @@ | |||
34 | /* How many pages do we try to swap or page in/out together? */ | 34 | /* How many pages do we try to swap or page in/out together? */ |
35 | int page_cluster; | 35 | int page_cluster; |
36 | 36 | ||
37 | #ifdef CONFIG_HUGETLB_PAGE | ||
38 | |||
39 | void put_page(struct page *page) | 37 | void put_page(struct page *page) |
40 | { | 38 | { |
41 | if (unlikely(PageCompound(page))) { | 39 | if (unlikely(PageCompound(page))) { |
@@ -52,7 +50,6 @@ void put_page(struct page *page) | |||
52 | __page_cache_release(page); | 50 | __page_cache_release(page); |
53 | } | 51 | } |
54 | EXPORT_SYMBOL(put_page); | 52 | EXPORT_SYMBOL(put_page); |
55 | #endif | ||
56 | 53 | ||
57 | /* | 54 | /* |
58 | * Writeback is about to end against a page which has been marked for immediate | 55 | * Writeback is about to end against a page which has been marked for immediate |