diff options
author | Nick Piggin <npiggin@suse.de> | 2008-10-18 23:26:57 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-10-20 11:52:31 -0400 |
commit | f45840b5c128445da70e7ec33adc47b4a12bdaf4 (patch) | |
tree | 3815a03d12d1c69d71a48c44cd216c3e1e84272a /mm | |
parent | 9978ad583e100945b74e4f33e73317983ea32df9 (diff) |
mm: pagecache insertion fewer atomics
Setting and clearing the page locked when inserting it into swapcache /
pagecache when it has no other references can use non-atomic page flags
operations because no other CPU may be operating on it at this time.
This saves one atomic operation when inserting a page into pagecache.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm')
-rw-r--r-- | mm/swap_state.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/mm/swap_state.c b/mm/swap_state.c index 43cda7b4b808..3353c9029cef 100644 --- a/mm/swap_state.c +++ b/mm/swap_state.c | |||
@@ -303,7 +303,7 @@ struct page *read_swap_cache_async(swp_entry_t entry, gfp_t gfp_mask, | |||
303 | * re-using the just freed swap entry for an existing page. | 303 | * re-using the just freed swap entry for an existing page. |
304 | * May fail (-ENOMEM) if radix-tree node allocation failed. | 304 | * May fail (-ENOMEM) if radix-tree node allocation failed. |
305 | */ | 305 | */ |
306 | set_page_locked(new_page); | 306 | __set_page_locked(new_page); |
307 | SetPageSwapBacked(new_page); | 307 | SetPageSwapBacked(new_page); |
308 | err = add_to_swap_cache(new_page, entry, gfp_mask & GFP_KERNEL); | 308 | err = add_to_swap_cache(new_page, entry, gfp_mask & GFP_KERNEL); |
309 | if (likely(!err)) { | 309 | if (likely(!err)) { |
@@ -315,7 +315,7 @@ struct page *read_swap_cache_async(swp_entry_t entry, gfp_t gfp_mask, | |||
315 | return new_page; | 315 | return new_page; |
316 | } | 316 | } |
317 | ClearPageSwapBacked(new_page); | 317 | ClearPageSwapBacked(new_page); |
318 | clear_page_locked(new_page); | 318 | __clear_page_locked(new_page); |
319 | swap_free(entry); | 319 | swap_free(entry); |
320 | } while (err != -ENOMEM); | 320 | } while (err != -ENOMEM); |
321 | 321 | ||