aboutsummaryrefslogtreecommitdiffstats
path: root/mm
diff options
context:
space:
mode:
authorJoonsoo Kim <iamjoonsoo.kim@lge.com>2013-09-11 17:21:02 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2013-09-11 18:57:27 -0400
commitc0d934ba278935fa751057091fe4a7c02d814f68 (patch)
treee1d34d7aaa2b486fc61162f7f37c4a20732dd371 /mm
parentb2261026825ed34066b24069359d118098bb1876 (diff)
mm, hugetlb: remove redundant list_empty check in gather_surplus_pages()
If list is empty, list_for_each_entry_safe() doesn't do anything. So, this check is redundant. Remove it. Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com> Acked-by: Michal Hocko <mhocko@suse.cz> Reviewed-by: Wanpeng Li <liwanp@linux.vnet.ibm.com> Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> Acked-by: Hillf Danton <dhillf@gmail.com> Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> Cc: Wanpeng Li <liwanp@linux.vnet.ibm.com> Cc: Rik van Riel <riel@redhat.com> Cc: Mel Gorman <mgorman@suse.de> Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> Cc: Hugh Dickins <hughd@google.com> Cc: Davidlohr Bueso <davidlohr.bueso@hp.com> Cc: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm')
-rw-r--r--mm/hugetlb.c7
1 files changed, 2 insertions, 5 deletions
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 08b7595fe3c1..a13be48b818b 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -1037,11 +1037,8 @@ free:
1037 spin_unlock(&hugetlb_lock); 1037 spin_unlock(&hugetlb_lock);
1038 1038
1039 /* Free unnecessary surplus pages to the buddy allocator */ 1039 /* Free unnecessary surplus pages to the buddy allocator */
1040 if (!list_empty(&surplus_list)) { 1040 list_for_each_entry_safe(page, tmp, &surplus_list, lru)
1041 list_for_each_entry_safe(page, tmp, &surplus_list, lru) { 1041 put_page(page);
1042 put_page(page);
1043 }
1044 }
1045 spin_lock(&hugetlb_lock); 1042 spin_lock(&hugetlb_lock);
1046 1043
1047 return ret; 1044 return ret;