diff options
author | Christopher Yeoh <cyeoh@au1.ibm.com> | 2012-05-31 19:26:42 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-05-31 20:49:32 -0400 |
commit | ac34ebb3a67e699edcb5ac72f19d31679369dfaa (patch) | |
tree | 21785208005952128545c0d7804c2dddf177766f /mm | |
parent | ee62c6b2dc93c09585b51fad18449dc5edb9977f (diff) |
aio/vfs: cleanup of rw_copy_check_uvector() and compat_rw_copy_check_uvector()
A cleanup of rw_copy_check_uvector and compat_rw_copy_check_uvector after
changes made to support CMA in an earlier patch.
Rather than having an additional check_access parameter to these
functions, the first paramater type is overloaded to allow the caller to
specify CHECK_IOVEC_ONLY which means check that the contents of the iovec
are valid, but do not check the memory that they point to. This is used
by process_vm_readv/writev where we need to validate that a iovec passed
to the syscall is valid but do not want to check the memory that it points
to at this point because it refers to an address space in another process.
Signed-off-by: Chris Yeoh <yeohc@au1.ibm.com>
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm')
-rw-r--r-- | mm/process_vm_access.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/mm/process_vm_access.c b/mm/process_vm_access.c index c20ff48994c2..926b46649749 100644 --- a/mm/process_vm_access.c +++ b/mm/process_vm_access.c | |||
@@ -371,15 +371,15 @@ static ssize_t process_vm_rw(pid_t pid, | |||
371 | /* Check iovecs */ | 371 | /* Check iovecs */ |
372 | if (vm_write) | 372 | if (vm_write) |
373 | rc = rw_copy_check_uvector(WRITE, lvec, liovcnt, UIO_FASTIOV, | 373 | rc = rw_copy_check_uvector(WRITE, lvec, liovcnt, UIO_FASTIOV, |
374 | iovstack_l, &iov_l, 1); | 374 | iovstack_l, &iov_l); |
375 | else | 375 | else |
376 | rc = rw_copy_check_uvector(READ, lvec, liovcnt, UIO_FASTIOV, | 376 | rc = rw_copy_check_uvector(READ, lvec, liovcnt, UIO_FASTIOV, |
377 | iovstack_l, &iov_l, 1); | 377 | iovstack_l, &iov_l); |
378 | if (rc <= 0) | 378 | if (rc <= 0) |
379 | goto free_iovecs; | 379 | goto free_iovecs; |
380 | 380 | ||
381 | rc = rw_copy_check_uvector(READ, rvec, riovcnt, UIO_FASTIOV, | 381 | rc = rw_copy_check_uvector(CHECK_IOVEC_ONLY, rvec, riovcnt, UIO_FASTIOV, |
382 | iovstack_r, &iov_r, 0); | 382 | iovstack_r, &iov_r); |
383 | if (rc <= 0) | 383 | if (rc <= 0) |
384 | goto free_iovecs; | 384 | goto free_iovecs; |
385 | 385 | ||
@@ -438,16 +438,16 @@ compat_process_vm_rw(compat_pid_t pid, | |||
438 | if (vm_write) | 438 | if (vm_write) |
439 | rc = compat_rw_copy_check_uvector(WRITE, lvec, liovcnt, | 439 | rc = compat_rw_copy_check_uvector(WRITE, lvec, liovcnt, |
440 | UIO_FASTIOV, iovstack_l, | 440 | UIO_FASTIOV, iovstack_l, |
441 | &iov_l, 1); | 441 | &iov_l); |
442 | else | 442 | else |
443 | rc = compat_rw_copy_check_uvector(READ, lvec, liovcnt, | 443 | rc = compat_rw_copy_check_uvector(READ, lvec, liovcnt, |
444 | UIO_FASTIOV, iovstack_l, | 444 | UIO_FASTIOV, iovstack_l, |
445 | &iov_l, 1); | 445 | &iov_l); |
446 | if (rc <= 0) | 446 | if (rc <= 0) |
447 | goto free_iovecs; | 447 | goto free_iovecs; |
448 | rc = compat_rw_copy_check_uvector(READ, rvec, riovcnt, | 448 | rc = compat_rw_copy_check_uvector(CHECK_IOVEC_ONLY, rvec, riovcnt, |
449 | UIO_FASTIOV, iovstack_r, | 449 | UIO_FASTIOV, iovstack_r, |
450 | &iov_r, 0); | 450 | &iov_r); |
451 | if (rc <= 0) | 451 | if (rc <= 0) |
452 | goto free_iovecs; | 452 | goto free_iovecs; |
453 | 453 | ||