diff options
author | David Howells <dhowells@redhat.com> | 2008-11-13 18:39:16 -0500 |
---|---|---|
committer | James Morris <jmorris@namei.org> | 2008-11-13 18:39:16 -0500 |
commit | b6dff3ec5e116e3af6f537d4caedcad6b9e5082a (patch) | |
tree | 9e76f972eb7ce9b84e0146c8e4126a3f86acb428 /mm | |
parent | 15a2460ed0af7538ca8e6c610fe607a2cd9da142 (diff) |
CRED: Separate task security context from task_struct
Separate the task security context from task_struct. At this point, the
security data is temporarily embedded in the task_struct with two pointers
pointing to it.
Note that the Alpha arch is altered as it refers to (E)UID and (E)GID in
entry.S via asm-offsets.
With comment fixes Signed-off-by: Marc Dionne <marc.c.dionne@gmail.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Acked-by: James Morris <jmorris@namei.org>
Acked-by: Serge Hallyn <serue@us.ibm.com>
Signed-off-by: James Morris <jmorris@namei.org>
Diffstat (limited to 'mm')
-rw-r--r-- | mm/mempolicy.c | 10 | ||||
-rw-r--r-- | mm/migrate.c | 10 | ||||
-rw-r--r-- | mm/oom_kill.c | 2 |
3 files changed, 11 insertions, 11 deletions
diff --git a/mm/mempolicy.c b/mm/mempolicy.c index 07a96474077d..b23492ee3e50 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c | |||
@@ -1110,12 +1110,12 @@ asmlinkage long sys_migrate_pages(pid_t pid, unsigned long maxnode, | |||
1110 | const unsigned long __user *old_nodes, | 1110 | const unsigned long __user *old_nodes, |
1111 | const unsigned long __user *new_nodes) | 1111 | const unsigned long __user *new_nodes) |
1112 | { | 1112 | { |
1113 | struct cred *cred, *tcred; | ||
1113 | struct mm_struct *mm; | 1114 | struct mm_struct *mm; |
1114 | struct task_struct *task; | 1115 | struct task_struct *task; |
1115 | nodemask_t old; | 1116 | nodemask_t old; |
1116 | nodemask_t new; | 1117 | nodemask_t new; |
1117 | nodemask_t task_nodes; | 1118 | nodemask_t task_nodes; |
1118 | uid_t uid, euid; | ||
1119 | int err; | 1119 | int err; |
1120 | 1120 | ||
1121 | err = get_nodes(&old, old_nodes, maxnode); | 1121 | err = get_nodes(&old, old_nodes, maxnode); |
@@ -1145,10 +1145,10 @@ asmlinkage long sys_migrate_pages(pid_t pid, unsigned long maxnode, | |||
1145 | * capabilities, superuser privileges or the same | 1145 | * capabilities, superuser privileges or the same |
1146 | * userid as the target process. | 1146 | * userid as the target process. |
1147 | */ | 1147 | */ |
1148 | uid = current_uid(); | 1148 | cred = current->cred; |
1149 | euid = current_euid(); | 1149 | tcred = task->cred; |
1150 | if (euid != task->suid && euid != task->uid && | 1150 | if (cred->euid != tcred->suid && cred->euid != tcred->uid && |
1151 | uid != task->suid && uid != task->uid && | 1151 | cred->uid != tcred->suid && cred->uid != tcred->uid && |
1152 | !capable(CAP_SYS_NICE)) { | 1152 | !capable(CAP_SYS_NICE)) { |
1153 | err = -EPERM; | 1153 | err = -EPERM; |
1154 | goto out; | 1154 | goto out; |
diff --git a/mm/migrate.c b/mm/migrate.c index 6263c24c4afe..794443da1b4f 100644 --- a/mm/migrate.c +++ b/mm/migrate.c | |||
@@ -1045,10 +1045,10 @@ asmlinkage long sys_move_pages(pid_t pid, unsigned long nr_pages, | |||
1045 | const int __user *nodes, | 1045 | const int __user *nodes, |
1046 | int __user *status, int flags) | 1046 | int __user *status, int flags) |
1047 | { | 1047 | { |
1048 | struct cred *cred, *tcred; | ||
1048 | struct task_struct *task; | 1049 | struct task_struct *task; |
1049 | struct mm_struct *mm; | 1050 | struct mm_struct *mm; |
1050 | int err; | 1051 | int err; |
1051 | uid_t uid, euid; | ||
1052 | 1052 | ||
1053 | /* Check flags */ | 1053 | /* Check flags */ |
1054 | if (flags & ~(MPOL_MF_MOVE|MPOL_MF_MOVE_ALL)) | 1054 | if (flags & ~(MPOL_MF_MOVE|MPOL_MF_MOVE_ALL)) |
@@ -1076,10 +1076,10 @@ asmlinkage long sys_move_pages(pid_t pid, unsigned long nr_pages, | |||
1076 | * capabilities, superuser privileges or the same | 1076 | * capabilities, superuser privileges or the same |
1077 | * userid as the target process. | 1077 | * userid as the target process. |
1078 | */ | 1078 | */ |
1079 | uid = current_uid(); | 1079 | cred = current->cred; |
1080 | euid = current_euid(); | 1080 | tcred = task->cred; |
1081 | if (euid != task->suid && euid != task->uid && | 1081 | if (cred->euid != tcred->suid && cred->euid != tcred->uid && |
1082 | uid != task->suid && uid != task->uid && | 1082 | cred->uid != tcred->suid && cred->uid != tcred->uid && |
1083 | !capable(CAP_SYS_NICE)) { | 1083 | !capable(CAP_SYS_NICE)) { |
1084 | err = -EPERM; | 1084 | err = -EPERM; |
1085 | goto out; | 1085 | goto out; |
diff --git a/mm/oom_kill.c b/mm/oom_kill.c index 34a458aa7997..3af787ba2077 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c | |||
@@ -298,7 +298,7 @@ static void dump_tasks(const struct mem_cgroup *mem) | |||
298 | 298 | ||
299 | task_lock(p); | 299 | task_lock(p); |
300 | printk(KERN_INFO "[%5d] %5d %5d %8lu %8lu %3d %3d %s\n", | 300 | printk(KERN_INFO "[%5d] %5d %5d %8lu %8lu %3d %3d %s\n", |
301 | p->pid, p->uid, p->tgid, p->mm->total_vm, | 301 | p->pid, p->cred->uid, p->tgid, p->mm->total_vm, |
302 | get_mm_rss(p->mm), (int)task_cpu(p), p->oomkilladj, | 302 | get_mm_rss(p->mm), (int)task_cpu(p), p->oomkilladj, |
303 | p->comm); | 303 | p->comm); |
304 | task_unlock(p); | 304 | task_unlock(p); |