diff options
author | Hugh Dickins <hugh@veritas.com> | 2006-01-06 03:10:55 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-01-06 11:33:24 -0500 |
commit | c484d41042e6ccb88089ca41e3b3eed1bafdae21 (patch) | |
tree | c65e522698456899ed5ab058373d3ca2aad1650b /mm | |
parent | 161599ff39a3c3cdea0a1be05ac53accd2c45cdd (diff) |
[PATCH] mm: free_pages_and_swap_cache opt
Minor optimization (though it doesn't help in the PREEMPT case, severely
constrained by small ZAP_BLOCK_SIZE). free_pages_and_swap_cache works in
chunks of 16, calling release_pages which works in chunks of PAGEVEC_SIZE.
But PAGEVEC_SIZE was dropped from 16 to 14 in 2.6.10, so we're now doing more
spin_lock_irq'ing than necessary: use PAGEVEC_SIZE throughout.
Signed-off-by: Hugh Dickins <hugh@veritas.com>
Signed-off-by: Nick Piggin <nickpiggin@yahoo.com.au>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'mm')
-rw-r--r-- | mm/swap_state.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/mm/swap_state.c b/mm/swap_state.c index 0df9a57b1de8..fc2aecb70a95 100644 --- a/mm/swap_state.c +++ b/mm/swap_state.c | |||
@@ -14,6 +14,7 @@ | |||
14 | #include <linux/pagemap.h> | 14 | #include <linux/pagemap.h> |
15 | #include <linux/buffer_head.h> | 15 | #include <linux/buffer_head.h> |
16 | #include <linux/backing-dev.h> | 16 | #include <linux/backing-dev.h> |
17 | #include <linux/pagevec.h> | ||
17 | 18 | ||
18 | #include <asm/pgtable.h> | 19 | #include <asm/pgtable.h> |
19 | 20 | ||
@@ -272,12 +273,11 @@ void free_page_and_swap_cache(struct page *page) | |||
272 | */ | 273 | */ |
273 | void free_pages_and_swap_cache(struct page **pages, int nr) | 274 | void free_pages_and_swap_cache(struct page **pages, int nr) |
274 | { | 275 | { |
275 | int chunk = 16; | ||
276 | struct page **pagep = pages; | 276 | struct page **pagep = pages; |
277 | 277 | ||
278 | lru_add_drain(); | 278 | lru_add_drain(); |
279 | while (nr) { | 279 | while (nr) { |
280 | int todo = min(chunk, nr); | 280 | int todo = min(nr, PAGEVEC_SIZE); |
281 | int i; | 281 | int i; |
282 | 282 | ||
283 | for (i = 0; i < todo; i++) | 283 | for (i = 0; i < todo; i++) |