diff options
author | Christoph Lameter <cl@linux.com> | 2010-12-06 12:40:02 -0500 |
---|---|---|
committer | Tejun Heo <tj@kernel.org> | 2010-12-17 09:18:04 -0500 |
commit | 908ee0f122bf2a67414854af5b90c6621d186a71 (patch) | |
tree | 5394b0b65dada76fed551d44ca0561fe5b7ac839 /mm/vmstat.c | |
parent | 275c8b93288ef0c2281e414e069ea8ed4bad03f7 (diff) |
vmstat: Use this_cpu_inc_return for vm statistics
this_cpu_inc_return() saves us a memory access there. Code
size does not change.
V1->V2:
- Fixed the location of the __per_cpu pointer attributes
- Sparse checked
V2->V3:
- Move fixes to __percpu attribute usage to earlier patch
Reviewed-by: Pekka Enberg <penberg@kernel.org>
Acked-by: H. Peter Anvin <hpa@zytor.com>
Signed-off-by: Christoph Lameter <cl@linux.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'mm/vmstat.c')
-rw-r--r-- | mm/vmstat.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/mm/vmstat.c b/mm/vmstat.c index 3ad909d9600f..f9a7bc89fd10 100644 --- a/mm/vmstat.c +++ b/mm/vmstat.c | |||
@@ -227,9 +227,7 @@ void __inc_zone_state(struct zone *zone, enum zone_stat_item item) | |||
227 | s8 __percpu *p = pcp->vm_stat_diff + item; | 227 | s8 __percpu *p = pcp->vm_stat_diff + item; |
228 | s8 v, t; | 228 | s8 v, t; |
229 | 229 | ||
230 | __this_cpu_inc(*p); | 230 | v = __this_cpu_inc_return(*p); |
231 | |||
232 | v = __this_cpu_read(*p); | ||
233 | t = __this_cpu_read(pcp->stat_threshold); | 231 | t = __this_cpu_read(pcp->stat_threshold); |
234 | if (unlikely(v > t)) { | 232 | if (unlikely(v > t)) { |
235 | s8 overstep = t >> 1; | 233 | s8 overstep = t >> 1; |
@@ -251,9 +249,7 @@ void __dec_zone_state(struct zone *zone, enum zone_stat_item item) | |||
251 | s8 __percpu *p = pcp->vm_stat_diff + item; | 249 | s8 __percpu *p = pcp->vm_stat_diff + item; |
252 | s8 v, t; | 250 | s8 v, t; |
253 | 251 | ||
254 | __this_cpu_dec(*p); | 252 | v = __this_cpu_dec_return(*p); |
255 | |||
256 | v = __this_cpu_read(*p); | ||
257 | t = __this_cpu_read(pcp->stat_threshold); | 253 | t = __this_cpu_read(pcp->stat_threshold); |
258 | if (unlikely(v < - t)) { | 254 | if (unlikely(v < - t)) { |
259 | s8 overstep = t >> 1; | 255 | s8 overstep = t >> 1; |