diff options
author | Nick Piggin <npiggin@suse.de> | 2010-07-20 16:24:25 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-07-20 19:25:40 -0400 |
commit | a6aa62a0909b9ccb1f8b0d2653920ba071037972 (patch) | |
tree | 2df66e9a20cdb8fac10a1979c6b678e98ee67f0a /mm/vmscan.c | |
parent | c61284e99191b2284fb74dae6961d4d09e4e59e8 (diff) |
mm/vmscan.c: fix mapping use after free
We need lock_page_nosync() here because we have no reference to the
mapping when taking the page lock.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Reviewed-by: Johannes Weiner <hannes@cmpxchg.org>
Cc: Mel Gorman <mel@csn.ul.ie>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/vmscan.c')
-rw-r--r-- | mm/vmscan.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mm/vmscan.c b/mm/vmscan.c index 199fa436c0dd..b94fe1b3da43 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c | |||
@@ -298,7 +298,7 @@ static int may_write_to_queue(struct backing_dev_info *bdi) | |||
298 | static void handle_write_error(struct address_space *mapping, | 298 | static void handle_write_error(struct address_space *mapping, |
299 | struct page *page, int error) | 299 | struct page *page, int error) |
300 | { | 300 | { |
301 | lock_page(page); | 301 | lock_page_nosync(page); |
302 | if (page_mapping(page) == mapping) | 302 | if (page_mapping(page) == mapping) |
303 | mapping_set_error(mapping, error); | 303 | mapping_set_error(mapping, error); |
304 | unlock_page(page); | 304 | unlock_page(page); |