diff options
author | David Rientjes <rientjes@google.com> | 2007-10-17 02:25:54 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-10-17 11:42:45 -0400 |
commit | e815af95f94914993bbad279c71cf5fef9f4eaac (patch) | |
tree | 492e0d3e8d3303f37cf9fb0beecf952a1c828c53 /mm/vmscan.c | |
parent | 70e24bdf6d2fead14631e72a07fba012400c521e (diff) |
oom: change all_unreclaimable zone member to flags
Convert the int all_unreclaimable member of struct zone to unsigned long
flags. This can now be used to specify several different zone flags such as
all_unreclaimable and reclaim_in_progress, which can now be removed and
converted to a per-zone flag.
Flags are set and cleared as follows:
zone_set_flag(struct zone *zone, zone_flags_t flag)
zone_clear_flag(struct zone *zone, zone_flags_t flag)
Defines the first zone flags, ZONE_ALL_UNRECLAIMABLE and ZONE_RECLAIM_LOCKED,
which have the same semantics as the old zone->all_unreclaimable and
zone->reclaim_in_progress, respectively. Also converts all current users that
set or clear either flag to use the new interface.
Helper functions are defined to test the flags:
int zone_is_all_unreclaimable(const struct zone *zone)
int zone_is_reclaim_locked(const struct zone *zone)
All flag operators are of the atomic variety because there are currently
readers that are implemented that do not take zone->lock.
[akpm@linux-foundation.org: add needed include]
Cc: Andrea Arcangeli <andrea@suse.de>
Acked-by: Christoph Lameter <clameter@sgi.com>
Signed-off-by: David Rientjes <rientjes@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/vmscan.c')
-rw-r--r-- | mm/vmscan.c | 25 |
1 files changed, 13 insertions, 12 deletions
diff --git a/mm/vmscan.c b/mm/vmscan.c index bbd194630c5b..d8893dc2d4eb 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c | |||
@@ -1108,7 +1108,7 @@ static unsigned long shrink_zone(int priority, struct zone *zone, | |||
1108 | unsigned long nr_to_scan; | 1108 | unsigned long nr_to_scan; |
1109 | unsigned long nr_reclaimed = 0; | 1109 | unsigned long nr_reclaimed = 0; |
1110 | 1110 | ||
1111 | atomic_inc(&zone->reclaim_in_progress); | 1111 | zone_set_flag(zone, ZONE_RECLAIM_LOCKED); |
1112 | 1112 | ||
1113 | /* | 1113 | /* |
1114 | * Add one to `nr_to_scan' just to make sure that the kernel will | 1114 | * Add one to `nr_to_scan' just to make sure that the kernel will |
@@ -1149,7 +1149,7 @@ static unsigned long shrink_zone(int priority, struct zone *zone, | |||
1149 | 1149 | ||
1150 | throttle_vm_writeout(sc->gfp_mask); | 1150 | throttle_vm_writeout(sc->gfp_mask); |
1151 | 1151 | ||
1152 | atomic_dec(&zone->reclaim_in_progress); | 1152 | zone_clear_flag(zone, ZONE_RECLAIM_LOCKED); |
1153 | return nr_reclaimed; | 1153 | return nr_reclaimed; |
1154 | } | 1154 | } |
1155 | 1155 | ||
@@ -1187,7 +1187,7 @@ static unsigned long shrink_zones(int priority, struct zone **zones, | |||
1187 | 1187 | ||
1188 | note_zone_scanning_priority(zone, priority); | 1188 | note_zone_scanning_priority(zone, priority); |
1189 | 1189 | ||
1190 | if (zone->all_unreclaimable && priority != DEF_PRIORITY) | 1190 | if (zone_is_all_unreclaimable(zone) && priority != DEF_PRIORITY) |
1191 | continue; /* Let kswapd poll it */ | 1191 | continue; /* Let kswapd poll it */ |
1192 | 1192 | ||
1193 | sc->all_unreclaimable = 0; | 1193 | sc->all_unreclaimable = 0; |
@@ -1368,7 +1368,8 @@ loop_again: | |||
1368 | if (!populated_zone(zone)) | 1368 | if (!populated_zone(zone)) |
1369 | continue; | 1369 | continue; |
1370 | 1370 | ||
1371 | if (zone->all_unreclaimable && priority != DEF_PRIORITY) | 1371 | if (zone_is_all_unreclaimable(zone) && |
1372 | priority != DEF_PRIORITY) | ||
1372 | continue; | 1373 | continue; |
1373 | 1374 | ||
1374 | if (!zone_watermark_ok(zone, order, zone->pages_high, | 1375 | if (!zone_watermark_ok(zone, order, zone->pages_high, |
@@ -1403,7 +1404,8 @@ loop_again: | |||
1403 | if (!populated_zone(zone)) | 1404 | if (!populated_zone(zone)) |
1404 | continue; | 1405 | continue; |
1405 | 1406 | ||
1406 | if (zone->all_unreclaimable && priority != DEF_PRIORITY) | 1407 | if (zone_is_all_unreclaimable(zone) && |
1408 | priority != DEF_PRIORITY) | ||
1407 | continue; | 1409 | continue; |
1408 | 1410 | ||
1409 | if (!zone_watermark_ok(zone, order, zone->pages_high, | 1411 | if (!zone_watermark_ok(zone, order, zone->pages_high, |
@@ -1424,12 +1426,13 @@ loop_again: | |||
1424 | lru_pages); | 1426 | lru_pages); |
1425 | nr_reclaimed += reclaim_state->reclaimed_slab; | 1427 | nr_reclaimed += reclaim_state->reclaimed_slab; |
1426 | total_scanned += sc.nr_scanned; | 1428 | total_scanned += sc.nr_scanned; |
1427 | if (zone->all_unreclaimable) | 1429 | if (zone_is_all_unreclaimable(zone)) |
1428 | continue; | 1430 | continue; |
1429 | if (nr_slab == 0 && zone->pages_scanned >= | 1431 | if (nr_slab == 0 && zone->pages_scanned >= |
1430 | (zone_page_state(zone, NR_ACTIVE) | 1432 | (zone_page_state(zone, NR_ACTIVE) |
1431 | + zone_page_state(zone, NR_INACTIVE)) * 6) | 1433 | + zone_page_state(zone, NR_INACTIVE)) * 6) |
1432 | zone->all_unreclaimable = 1; | 1434 | zone_set_flag(zone, |
1435 | ZONE_ALL_UNRECLAIMABLE); | ||
1433 | /* | 1436 | /* |
1434 | * If we've done a decent amount of scanning and | 1437 | * If we've done a decent amount of scanning and |
1435 | * the reclaim ratio is low, start doing writepage | 1438 | * the reclaim ratio is low, start doing writepage |
@@ -1595,7 +1598,7 @@ static unsigned long shrink_all_zones(unsigned long nr_pages, int prio, | |||
1595 | if (!populated_zone(zone)) | 1598 | if (!populated_zone(zone)) |
1596 | continue; | 1599 | continue; |
1597 | 1600 | ||
1598 | if (zone->all_unreclaimable && prio != DEF_PRIORITY) | 1601 | if (zone_is_all_unreclaimable(zone) && prio != DEF_PRIORITY) |
1599 | continue; | 1602 | continue; |
1600 | 1603 | ||
1601 | /* For pass = 0 we don't shrink the active list */ | 1604 | /* For pass = 0 we don't shrink the active list */ |
@@ -1919,10 +1922,8 @@ int zone_reclaim(struct zone *zone, gfp_t gfp_mask, unsigned int order) | |||
1919 | * not have reclaimable pages and if we should not delay the allocation | 1922 | * not have reclaimable pages and if we should not delay the allocation |
1920 | * then do not scan. | 1923 | * then do not scan. |
1921 | */ | 1924 | */ |
1922 | if (!(gfp_mask & __GFP_WAIT) || | 1925 | if (!(gfp_mask & __GFP_WAIT) || zone_is_all_unreclaimable(zone) || |
1923 | zone->all_unreclaimable || | 1926 | zone_is_reclaim_locked(zone) || (current->flags & PF_MEMALLOC)) |
1924 | atomic_read(&zone->reclaim_in_progress) > 0 || | ||
1925 | (current->flags & PF_MEMALLOC)) | ||
1926 | return 0; | 1927 | return 0; |
1927 | 1928 | ||
1928 | /* | 1929 | /* |