diff options
author | Hugh Dickins <hugh@veritas.com> | 2005-10-29 21:16:05 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2005-10-30 00:40:38 -0400 |
commit | 4294621f41a85497019fae64341aa5351a1921b7 (patch) | |
tree | fdeb7eb44384a99d0679ffa6de5019bab0ea2166 /mm/swapfile.c | |
parent | 404351e67a9facb475abf1492245374a28d13e90 (diff) |
[PATCH] mm: rss = file_rss + anon_rss
I was lazy when we added anon_rss, and chose to change as few places as
possible. So currently each anonymous page has to be counted twice, in rss
and in anon_rss. Which won't be so good if those are atomic counts in some
configurations.
Change that around: keep file_rss and anon_rss separately, and add them
together (with get_mm_rss macro) when the total is needed - reading two
atomics is much cheaper than updating two atomics. And update anon_rss
upfront, typically in memory.c, not tucked away in page_add_anon_rmap.
Signed-off-by: Hugh Dickins <hugh@veritas.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'mm/swapfile.c')
-rw-r--r-- | mm/swapfile.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mm/swapfile.c b/mm/swapfile.c index 05c851291241..296e0bbf7836 100644 --- a/mm/swapfile.c +++ b/mm/swapfile.c | |||
@@ -407,7 +407,7 @@ void free_swap_and_cache(swp_entry_t entry) | |||
407 | static void unuse_pte(struct vm_area_struct *vma, pte_t *pte, | 407 | static void unuse_pte(struct vm_area_struct *vma, pte_t *pte, |
408 | unsigned long addr, swp_entry_t entry, struct page *page) | 408 | unsigned long addr, swp_entry_t entry, struct page *page) |
409 | { | 409 | { |
410 | inc_mm_counter(vma->vm_mm, rss); | 410 | inc_mm_counter(vma->vm_mm, anon_rss); |
411 | get_page(page); | 411 | get_page(page); |
412 | set_pte_at(vma->vm_mm, addr, pte, | 412 | set_pte_at(vma->vm_mm, addr, pte, |
413 | pte_mkold(mk_pte(page, vma->vm_page_prot))); | 413 | pte_mkold(mk_pte(page, vma->vm_page_prot))); |