diff options
author | Roman Zippel <zippel@linux-m68k.org> | 2008-05-01 07:34:31 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-05-01 11:03:58 -0400 |
commit | f8bd2258e2d520dff28c855658bd24bdafb5102d (patch) | |
tree | d76db1dc858cb316bc7d5b8473f690a753fd2c93 /mm/slub.c | |
parent | 6f6d6a1a6a1336431a6cba60ace9e97c3a496a19 (diff) |
remove div_long_long_rem
x86 is the only arch right now, which provides an optimized for
div_long_long_rem and it has the downside that one has to be very careful that
the divide doesn't overflow.
The API is a little akward, as the arguments for the unsigned divide are
signed. The signed version also doesn't handle a negative divisor and
produces worse code on 64bit archs.
There is little incentive to keep this API alive, so this converts the few
users to the new API.
Signed-off-by: Roman Zippel <zippel@linux-m68k.org>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: john stultz <johnstul@us.ibm.com>
Cc: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/slub.c')
-rw-r--r-- | mm/slub.c | 9 |
1 files changed, 4 insertions, 5 deletions
@@ -22,6 +22,7 @@ | |||
22 | #include <linux/debugobjects.h> | 22 | #include <linux/debugobjects.h> |
23 | #include <linux/kallsyms.h> | 23 | #include <linux/kallsyms.h> |
24 | #include <linux/memory.h> | 24 | #include <linux/memory.h> |
25 | #include <linux/math64.h> | ||
25 | 26 | ||
26 | /* | 27 | /* |
27 | * Lock order: | 28 | * Lock order: |
@@ -3621,12 +3622,10 @@ static int list_locations(struct kmem_cache *s, char *buf, | |||
3621 | len += sprintf(buf + len, "<not-available>"); | 3622 | len += sprintf(buf + len, "<not-available>"); |
3622 | 3623 | ||
3623 | if (l->sum_time != l->min_time) { | 3624 | if (l->sum_time != l->min_time) { |
3624 | unsigned long remainder; | ||
3625 | |||
3626 | len += sprintf(buf + len, " age=%ld/%ld/%ld", | 3625 | len += sprintf(buf + len, " age=%ld/%ld/%ld", |
3627 | l->min_time, | 3626 | l->min_time, |
3628 | div_long_long_rem(l->sum_time, l->count, &remainder), | 3627 | (long)div_u64(l->sum_time, l->count), |
3629 | l->max_time); | 3628 | l->max_time); |
3630 | } else | 3629 | } else |
3631 | len += sprintf(buf + len, " age=%ld", | 3630 | len += sprintf(buf + len, " age=%ld", |
3632 | l->min_time); | 3631 | l->min_time); |