diff options
author | Christoph Lameter <clameter@sgi.com> | 2007-10-17 02:25:51 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-10-17 11:42:45 -0400 |
commit | 4ba9b9d0ba0a49d91fa6417c7510ee36f48cf957 (patch) | |
tree | 191b4f45f926e44b882b1e87a9a85dc12230b892 /mm/slob.c | |
parent | b811c202a0edadaac7242ab834fe7ba409978ae7 (diff) |
Slab API: remove useless ctor parameter and reorder parameters
Slab constructors currently have a flags parameter that is never used. And
the order of the arguments is opposite to other slab functions. The object
pointer is placed before the kmem_cache pointer.
Convert
ctor(void *object, struct kmem_cache *s, unsigned long flags)
to
ctor(struct kmem_cache *s, void *object)
throughout the kernel
[akpm@linux-foundation.org: coupla fixes]
Signed-off-by: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/slob.c')
-rw-r--r-- | mm/slob.c | 6 |
1 files changed, 3 insertions, 3 deletions
@@ -499,12 +499,12 @@ struct kmem_cache { | |||
499 | unsigned int size, align; | 499 | unsigned int size, align; |
500 | unsigned long flags; | 500 | unsigned long flags; |
501 | const char *name; | 501 | const char *name; |
502 | void (*ctor)(void *, struct kmem_cache *, unsigned long); | 502 | void (*ctor)(struct kmem_cache *, void *); |
503 | }; | 503 | }; |
504 | 504 | ||
505 | struct kmem_cache *kmem_cache_create(const char *name, size_t size, | 505 | struct kmem_cache *kmem_cache_create(const char *name, size_t size, |
506 | size_t align, unsigned long flags, | 506 | size_t align, unsigned long flags, |
507 | void (*ctor)(void*, struct kmem_cache *, unsigned long)) | 507 | void (*ctor)(struct kmem_cache *, void *)) |
508 | { | 508 | { |
509 | struct kmem_cache *c; | 509 | struct kmem_cache *c; |
510 | 510 | ||
@@ -548,7 +548,7 @@ void *kmem_cache_alloc_node(struct kmem_cache *c, gfp_t flags, int node) | |||
548 | b = slob_new_page(flags, get_order(c->size), node); | 548 | b = slob_new_page(flags, get_order(c->size), node); |
549 | 549 | ||
550 | if (c->ctor) | 550 | if (c->ctor) |
551 | c->ctor(b, c, 0); | 551 | c->ctor(c, b); |
552 | 552 | ||
553 | return b; | 553 | return b; |
554 | } | 554 | } |