aboutsummaryrefslogtreecommitdiffstats
path: root/mm/slab_common.c
diff options
context:
space:
mode:
authorVladimir Davydov <vdavydov@parallels.com>2014-06-04 19:08:23 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2014-06-04 19:54:06 -0400
commit073ee1c6cd11cd190f4d0da84d9b4ba79d7b9e70 (patch)
treeb15246321eb6b1e4faea04a46f6ea998d608044e /mm/slab_common.c
parentb5ffc8560cf758422e85b786cca32cd7e1513a7f (diff)
memcg: get rid of memcg_create_cache_name
Instead of calling back to memcontrol.c from kmem_cache_create_memcg in order to just create the name of a per memcg cache, let's allocate it in place. We only need to pass the memcg name to kmem_cache_create_memcg for that - everything else can be done in slab_common.c. Signed-off-by: Vladimir Davydov <vdavydov@parallels.com> Acked-by: Michal Hocko <mhocko@suse.cz> Cc: Johannes Weiner <hannes@cmpxchg.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/slab_common.c')
-rw-r--r--mm/slab_common.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/mm/slab_common.c b/mm/slab_common.c
index 7e348cff814d..32175617cb75 100644
--- a/mm/slab_common.c
+++ b/mm/slab_common.c
@@ -264,13 +264,15 @@ EXPORT_SYMBOL(kmem_cache_create);
264 * kmem_cache_create_memcg - Create a cache for a memory cgroup. 264 * kmem_cache_create_memcg - Create a cache for a memory cgroup.
265 * @memcg: The memory cgroup the new cache is for. 265 * @memcg: The memory cgroup the new cache is for.
266 * @root_cache: The parent of the new cache. 266 * @root_cache: The parent of the new cache.
267 * @memcg_name: The name of the memory cgroup (used for naming the new cache).
267 * 268 *
268 * This function attempts to create a kmem cache that will serve allocation 269 * This function attempts to create a kmem cache that will serve allocation
269 * requests going from @memcg to @root_cache. The new cache inherits properties 270 * requests going from @memcg to @root_cache. The new cache inherits properties
270 * from its parent. 271 * from its parent.
271 */ 272 */
272struct kmem_cache *kmem_cache_create_memcg(struct mem_cgroup *memcg, 273struct kmem_cache *kmem_cache_create_memcg(struct mem_cgroup *memcg,
273 struct kmem_cache *root_cache) 274 struct kmem_cache *root_cache,
275 const char *memcg_name)
274{ 276{
275 struct kmem_cache *s = NULL; 277 struct kmem_cache *s = NULL;
276 char *cache_name; 278 char *cache_name;
@@ -280,7 +282,8 @@ struct kmem_cache *kmem_cache_create_memcg(struct mem_cgroup *memcg,
280 282
281 mutex_lock(&slab_mutex); 283 mutex_lock(&slab_mutex);
282 284
283 cache_name = memcg_create_cache_name(memcg, root_cache); 285 cache_name = kasprintf(GFP_KERNEL, "%s(%d:%s)", root_cache->name,
286 memcg_cache_id(memcg), memcg_name);
284 if (!cache_name) 287 if (!cache_name)
285 goto out_unlock; 288 goto out_unlock;
286 289