aboutsummaryrefslogtreecommitdiffstats
path: root/mm/page_alloc.c
diff options
context:
space:
mode:
authorHugh Dickins <hugh@veritas.com>2009-01-06 17:40:13 -0500
committerLinus Torvalds <torvalds@linux-foundation.org>2009-01-06 18:59:08 -0500
commit1e9e63650d6cb88e6d6d2ca6cc3ee276c26de4a3 (patch)
tree2fd95051128ef2ebfaad421ee919dab9e25459b2 /mm/page_alloc.c
parentd936cf9b39b06c8d2e0d7fb5e7b4f176e18dec69 (diff)
badpage: KERN_ALERT BUG instead of KERN_EMERG
bad_page() and rmap Eeek messages have said KERN_EMERG for a few years, which I've followed in print_bad_pte(). These are serious system errors, on a par with BUGs, but they're not quite emergencies, and we do our best to carry on: say KERN_ALERT "BUG: " like the x86 oops does. And remove the "Trying to fix it up, but a reboot is needed" line: it's not untrue, but I hope the KERN_ALERT "BUG: " conveys as much. Signed-off-by: Hugh Dickins <hugh@veritas.com> Cc: Nick Piggin <nickpiggin@yahoo.com.au> Cc: Christoph Lameter <cl@linux-foundation.org> Cc: Mel Gorman <mel@csn.ul.ie> Cc: Rik van Riel <riel@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/page_alloc.c')
-rw-r--r--mm/page_alloc.c9
1 files changed, 4 insertions, 5 deletions
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index d1a80f652c6f..d531e8ef9984 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -237,8 +237,8 @@ static void bad_page(struct page *page)
237 goto out; 237 goto out;
238 } 238 }
239 if (nr_unshown) { 239 if (nr_unshown) {
240 printk(KERN_EMERG 240 printk(KERN_ALERT
241 "Bad page state: %lu messages suppressed\n", 241 "BUG: Bad page state: %lu messages suppressed\n",
242 nr_unshown); 242 nr_unshown);
243 nr_unshown = 0; 243 nr_unshown = 0;
244 } 244 }
@@ -247,13 +247,12 @@ static void bad_page(struct page *page)
247 if (nr_shown++ == 0) 247 if (nr_shown++ == 0)
248 resume = jiffies + 60 * HZ; 248 resume = jiffies + 60 * HZ;
249 249
250 printk(KERN_EMERG "Bad page state in process %s pfn:%05lx\n", 250 printk(KERN_ALERT "BUG: Bad page state in process %s pfn:%05lx\n",
251 current->comm, page_to_pfn(page)); 251 current->comm, page_to_pfn(page));
252 printk(KERN_EMERG 252 printk(KERN_ALERT
253 "page:%p flags:%p count:%d mapcount:%d mapping:%p index:%lx\n", 253 "page:%p flags:%p count:%d mapcount:%d mapping:%p index:%lx\n",
254 page, (void *)page->flags, page_count(page), 254 page, (void *)page->flags, page_count(page),
255 page_mapcount(page), page->mapping, page->index); 255 page_mapcount(page), page->mapping, page->index);
256 printk(KERN_EMERG "Trying to fix it up, but a reboot is needed\n");
257 256
258 dump_stack(); 257 dump_stack();
259out: 258out: