diff options
author | Darrick J. Wong <darrick.wong@oracle.com> | 2013-04-29 18:07:25 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-04-29 18:54:33 -0400 |
commit | 7136851117744f1d291bed6d307432699d405109 (patch) | |
tree | 6dc7d6bef45e24ad0d3d5d1b9290a81109758172 /mm/page-writeback.c | |
parent | 106c992a5ebef28193cf5958e49ceff5e4aebb04 (diff) |
mm: make snapshotting pages for stable writes a per-bio operation
Walking a bio's page mappings has proved problematic, so create a new
bio flag to indicate that a bio's data needs to be snapshotted in order
to guarantee stable pages during writeback. Next, for the one user
(ext3/jbd) of snapshotting, hook all the places where writes can be
initiated without PG_writeback set, and set BIO_SNAP_STABLE there.
We must also flag journal "metadata" bios for stable writeout, since
file data can be written through the journal. Finally, the
MS_SNAP_STABLE mount flag (only used by ext3) is now superfluous, so get
rid of it.
[akpm@linux-foundation.org: rename _submit_bh()'s `flags' to `bio_flags', delobotomize the _submit_bh declaration]
[akpm@linux-foundation.org: teeny cleanup]
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Artem Bityutskiy <dedekind1@gmail.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/page-writeback.c')
-rw-r--r-- | mm/page-writeback.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/mm/page-writeback.c b/mm/page-writeback.c index efe68148f621..4514ad7415c3 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c | |||
@@ -2311,10 +2311,6 @@ void wait_for_stable_page(struct page *page) | |||
2311 | 2311 | ||
2312 | if (!bdi_cap_stable_pages_required(bdi)) | 2312 | if (!bdi_cap_stable_pages_required(bdi)) |
2313 | return; | 2313 | return; |
2314 | #ifdef CONFIG_NEED_BOUNCE_POOL | ||
2315 | if (mapping->host->i_sb->s_flags & MS_SNAP_STABLE) | ||
2316 | return; | ||
2317 | #endif /* CONFIG_NEED_BOUNCE_POOL */ | ||
2318 | 2314 | ||
2319 | wait_on_page_writeback(page); | 2315 | wait_on_page_writeback(page); |
2320 | } | 2316 | } |