diff options
author | KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> | 2010-08-09 20:19:36 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-08-09 23:45:01 -0400 |
commit | f88ccad5886d5a864b8b0d48c666ee9998dec53f (patch) | |
tree | fc6da2064c660a270cff82bb2f97f21ce537a369 /mm/oom_kill.c | |
parent | ab290adbaf8f46770f014ea87968de5baca29c30 (diff) |
oom: oom_kill_process() needs to check that p is unkillable
When oom_kill_allocating_task is enabled, an argument task of
oom_kill_process is not selected by select_bad_process(), It's just
out_of_memory() caller task. It mean the task can be unkillable. check
it first.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
Cc: David Rientjes <rientjes@google.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/oom_kill.c')
-rw-r--r-- | mm/oom_kill.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/mm/oom_kill.c b/mm/oom_kill.c index 2c993e47487f..3999747aef48 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c | |||
@@ -687,7 +687,8 @@ void out_of_memory(struct zonelist *zonelist, gfp_t gfp_mask, | |||
687 | check_panic_on_oom(constraint, gfp_mask, order); | 687 | check_panic_on_oom(constraint, gfp_mask, order); |
688 | 688 | ||
689 | read_lock(&tasklist_lock); | 689 | read_lock(&tasklist_lock); |
690 | if (sysctl_oom_kill_allocating_task) { | 690 | if (sysctl_oom_kill_allocating_task && |
691 | !oom_unkillable_task(current, NULL, nodemask)) { | ||
691 | /* | 692 | /* |
692 | * oom_kill_process() needs tasklist_lock held. If it returns | 693 | * oom_kill_process() needs tasklist_lock held. If it returns |
693 | * non-zero, current could not be killed so we must fallback to | 694 | * non-zero, current could not be killed so we must fallback to |