diff options
author | KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> | 2010-08-09 20:19:38 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-08-09 23:45:01 -0400 |
commit | a96cfd6e9176ad442233001b7d15e9ed42234320 (patch) | |
tree | 6aa70841f3f2c3ff39a75d0014b9a235810ccd08 /mm/oom_kill.c | |
parent | 113e27f36dff9895049df324f292474854750d21 (diff) |
oom: move OOM_DISABLE check from oom_kill_task to out_of_memory()
Presently if oom_kill_allocating_task is enabled and current have
OOM_DISABLED, following printk in oom_kill_process is called twice.
pr_err("%s: Kill process %d (%s) score %lu or sacrifice child\n",
message, task_pid_nr(p), p->comm, points);
So, OOM_DISABLE check should be more early.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Minchan Kim <minchan.kim@gmail.com>
Cc: David Rientjes <rientjes@google.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/oom_kill.c')
-rw-r--r-- | mm/oom_kill.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/mm/oom_kill.c b/mm/oom_kill.c index 011181ed41e3..79b34831ad79 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c | |||
@@ -424,7 +424,7 @@ static void dump_header(struct task_struct *p, gfp_t gfp_mask, int order, | |||
424 | static int oom_kill_task(struct task_struct *p) | 424 | static int oom_kill_task(struct task_struct *p) |
425 | { | 425 | { |
426 | p = find_lock_task_mm(p); | 426 | p = find_lock_task_mm(p); |
427 | if (!p || p->signal->oom_adj == OOM_DISABLE) { | 427 | if (!p) { |
428 | task_unlock(p); | 428 | task_unlock(p); |
429 | return 1; | 429 | return 1; |
430 | } | 430 | } |
@@ -686,7 +686,8 @@ void out_of_memory(struct zonelist *zonelist, gfp_t gfp_mask, | |||
686 | 686 | ||
687 | read_lock(&tasklist_lock); | 687 | read_lock(&tasklist_lock); |
688 | if (sysctl_oom_kill_allocating_task && | 688 | if (sysctl_oom_kill_allocating_task && |
689 | !oom_unkillable_task(current, NULL, nodemask)) { | 689 | !oom_unkillable_task(current, NULL, nodemask) && |
690 | (current->signal->oom_adj != OOM_DISABLE)) { | ||
690 | /* | 691 | /* |
691 | * oom_kill_process() needs tasklist_lock held. If it returns | 692 | * oom_kill_process() needs tasklist_lock held. If it returns |
692 | * non-zero, current could not be killed so we must fallback to | 693 | * non-zero, current could not be killed so we must fallback to |