diff options
author | Michel Lespinasse <walken@google.com> | 2013-02-22 19:32:47 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-02-23 20:50:11 -0500 |
commit | 41badc15cbad0350de34408c1b0c690f9df76d4b (patch) | |
tree | 2545134398b99b37259bf6412a0bb56442f120fa /mm/nommu.c | |
parent | 1869305009857cdeaabe6283bcdc2359c5784543 (diff) |
mm: make do_mmap_pgoff return populate as a size in bytes, not as a bool
do_mmap_pgoff() rounds up the desired size to the next PAGE_SIZE
multiple, however there was no equivalent code in mm_populate(), which
caused issues.
This could be fixed by introduced the same rounding in mm_populate(),
however I think it's preferable to make do_mmap_pgoff() return populate
as a size rather than as a boolean, so we don't have to duplicate the
size rounding logic in mm_populate().
Signed-off-by: Michel Lespinasse <walken@google.com>
Acked-by: Rik van Riel <riel@redhat.com>
Tested-by: Andy Lutomirski <luto@amacapital.net>
Cc: Greg Ungerer <gregungerer@westnet.com.au>
Cc: David Howells <dhowells@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/nommu.c')
-rw-r--r-- | mm/nommu.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/mm/nommu.c b/mm/nommu.c index 7296a5a280e7..18c1b932e2c4 100644 --- a/mm/nommu.c +++ b/mm/nommu.c | |||
@@ -1251,7 +1251,7 @@ unsigned long do_mmap_pgoff(struct file *file, | |||
1251 | unsigned long prot, | 1251 | unsigned long prot, |
1252 | unsigned long flags, | 1252 | unsigned long flags, |
1253 | unsigned long pgoff, | 1253 | unsigned long pgoff, |
1254 | bool *populate) | 1254 | unsigned long *populate) |
1255 | { | 1255 | { |
1256 | struct vm_area_struct *vma; | 1256 | struct vm_area_struct *vma; |
1257 | struct vm_region *region; | 1257 | struct vm_region *region; |
@@ -1261,7 +1261,7 @@ unsigned long do_mmap_pgoff(struct file *file, | |||
1261 | 1261 | ||
1262 | kenter(",%lx,%lx,%lx,%lx,%lx", addr, len, prot, flags, pgoff); | 1262 | kenter(",%lx,%lx,%lx,%lx,%lx", addr, len, prot, flags, pgoff); |
1263 | 1263 | ||
1264 | *populate = false; | 1264 | *populate = 0; |
1265 | 1265 | ||
1266 | /* decide whether we should attempt the mapping, and if so what sort of | 1266 | /* decide whether we should attempt the mapping, and if so what sort of |
1267 | * mapping */ | 1267 | * mapping */ |