diff options
author | Peter Zijlstra <a.p.zijlstra@chello.nl> | 2011-05-24 20:12:10 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2011-05-25 11:39:19 -0400 |
commit | 746b18d421da7f27e948e8af1ad82b6d0309324d (patch) | |
tree | d4e756977673b7b8166c00e34a21d85c5e26ea6e /mm/migrate.c | |
parent | 6111e4ca6829a0e8b092b8e5eeb6b5366091f29c (diff) |
mm: use refcounts for page_lock_anon_vma()
Convert page_lock_anon_vma() over to use refcounts. This is done to
prepare for the conversion of anon_vma from spinlock to mutex.
Sadly this inceases the cost of page_lock_anon_vma() from one to two
atomics, a follow up patch addresses this, lets keep that simple for now.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Acked-by: Hugh Dickins <hughd@google.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: David Miller <davem@davemloft.net>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Russell King <rmk@arm.linux.org.uk>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: Jeff Dike <jdike@addtoit.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Mel Gorman <mel@csn.ul.ie>
Cc: Nick Piggin <npiggin@kernel.dk>
Cc: Namhyung Kim <namhyung@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/migrate.c')
-rw-r--r-- | mm/migrate.c | 17 |
1 files changed, 4 insertions, 13 deletions
diff --git a/mm/migrate.c b/mm/migrate.c index 34132f8e9109..e4a5c912983d 100644 --- a/mm/migrate.c +++ b/mm/migrate.c | |||
@@ -721,15 +721,11 @@ static int unmap_and_move(new_page_t get_new_page, unsigned long private, | |||
721 | * Only page_lock_anon_vma() understands the subtleties of | 721 | * Only page_lock_anon_vma() understands the subtleties of |
722 | * getting a hold on an anon_vma from outside one of its mms. | 722 | * getting a hold on an anon_vma from outside one of its mms. |
723 | */ | 723 | */ |
724 | anon_vma = page_lock_anon_vma(page); | 724 | anon_vma = page_get_anon_vma(page); |
725 | if (anon_vma) { | 725 | if (anon_vma) { |
726 | /* | 726 | /* |
727 | * Take a reference count on the anon_vma if the | 727 | * Anon page |
728 | * page is mapped so that it is guaranteed to | ||
729 | * exist when the page is remapped later | ||
730 | */ | 728 | */ |
731 | get_anon_vma(anon_vma); | ||
732 | page_unlock_anon_vma(anon_vma); | ||
733 | } else if (PageSwapCache(page)) { | 729 | } else if (PageSwapCache(page)) { |
734 | /* | 730 | /* |
735 | * We cannot be sure that the anon_vma of an unmapped | 731 | * We cannot be sure that the anon_vma of an unmapped |
@@ -857,13 +853,8 @@ static int unmap_and_move_huge_page(new_page_t get_new_page, | |||
857 | lock_page(hpage); | 853 | lock_page(hpage); |
858 | } | 854 | } |
859 | 855 | ||
860 | if (PageAnon(hpage)) { | 856 | if (PageAnon(hpage)) |
861 | anon_vma = page_lock_anon_vma(hpage); | 857 | anon_vma = page_get_anon_vma(hpage); |
862 | if (anon_vma) { | ||
863 | get_anon_vma(anon_vma); | ||
864 | page_unlock_anon_vma(anon_vma); | ||
865 | } | ||
866 | } | ||
867 | 858 | ||
868 | try_to_unmap(hpage, TTU_MIGRATION|TTU_IGNORE_MLOCK|TTU_IGNORE_ACCESS); | 859 | try_to_unmap(hpage, TTU_MIGRATION|TTU_IGNORE_MLOCK|TTU_IGNORE_ACCESS); |
869 | 860 | ||