diff options
author | Christoph Lameter <clameter@sgi.com> | 2006-09-26 02:31:19 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-09-26 11:48:47 -0400 |
commit | 19655d3487001d7df0e10e9cbfc27c758b77c2b5 (patch) | |
tree | 8d0aaa216bd32bd64e3a9652fd34d40bdb9d1075 /mm/mempolicy.c | |
parent | 2f6726e54a9410e2e4cee864947c05e954051916 (diff) |
[PATCH] linearly index zone->node_zonelists[]
I wonder why we need this bitmask indexing into zone->node_zonelists[]?
We always start with the highest zone and then include all lower zones
if we build zonelists.
Are there really cases where we need allocation from ZONE_DMA or
ZONE_HIGHMEM but not ZONE_NORMAL? It seems that the current implementation
of highest_zone() makes that already impossible.
If we go linear on the index then gfp_zone() == highest_zone() and a lot
of definitions fall by the wayside.
We can now revert back to the use of gfp_zone() in mempolicy.c ;-)
Signed-off-by: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'mm/mempolicy.c')
-rw-r--r-- | mm/mempolicy.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mm/mempolicy.c b/mm/mempolicy.c index 7da4142ce960..c3429a710ab1 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c | |||
@@ -1101,7 +1101,7 @@ static struct zonelist *zonelist_policy(gfp_t gfp, struct mempolicy *policy) | |||
1101 | case MPOL_BIND: | 1101 | case MPOL_BIND: |
1102 | /* Lower zones don't get a policy applied */ | 1102 | /* Lower zones don't get a policy applied */ |
1103 | /* Careful: current->mems_allowed might have moved */ | 1103 | /* Careful: current->mems_allowed might have moved */ |
1104 | if (highest_zone(gfp) >= policy_zone) | 1104 | if (gfp_zone(gfp) >= policy_zone) |
1105 | if (cpuset_zonelist_valid_mems_allowed(policy->v.zonelist)) | 1105 | if (cpuset_zonelist_valid_mems_allowed(policy->v.zonelist)) |
1106 | return policy->v.zonelist; | 1106 | return policy->v.zonelist; |
1107 | /*FALL THROUGH*/ | 1107 | /*FALL THROUGH*/ |