diff options
author | Cody P Schafer <cody@linux.vnet.ibm.com> | 2013-07-03 18:02:11 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-07-03 19:07:29 -0400 |
commit | d702909f0aa14fe678d74d7f974aa66bfb211d0b (patch) | |
tree | 4c731abe0557a0749c38c14da77720f61544137a /mm/memory_hotplug.c | |
parent | aa47228a18e6d49369df877463095b899aff495f (diff) |
memory_hotplug: use pgdat_resize_lock() in __offline_pages()
mmzone.h documents node_size_lock (which pgdat_resize_lock() locks) as
follows:
* Must be held any time you expect node_start_pfn, node_present_pages
* or node_spanned_pages stay constant. [...]
So actually hold it when we update node_present_pages in __offline_pages().
[akpm@linux-foundation.org: fix build]
Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com>
Cc: David Rientjes <rientjes@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/memory_hotplug.c')
-rw-r--r-- | mm/memory_hotplug.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 527c51084bb8..a66d0023d219 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c | |||
@@ -1492,6 +1492,7 @@ static int __ref __offline_pages(unsigned long start_pfn, | |||
1492 | unsigned long pfn, nr_pages, expire; | 1492 | unsigned long pfn, nr_pages, expire; |
1493 | long offlined_pages; | 1493 | long offlined_pages; |
1494 | int ret, drain, retry_max, node; | 1494 | int ret, drain, retry_max, node; |
1495 | unsigned long flags; | ||
1495 | struct zone *zone; | 1496 | struct zone *zone; |
1496 | struct memory_notify arg; | 1497 | struct memory_notify arg; |
1497 | 1498 | ||
@@ -1585,7 +1586,11 @@ repeat: | |||
1585 | /* removal success */ | 1586 | /* removal success */ |
1586 | zone->managed_pages -= offlined_pages; | 1587 | zone->managed_pages -= offlined_pages; |
1587 | zone->present_pages -= offlined_pages; | 1588 | zone->present_pages -= offlined_pages; |
1589 | |||
1590 | pgdat_resize_lock(zone->zone_pgdat, &flags); | ||
1588 | zone->zone_pgdat->node_present_pages -= offlined_pages; | 1591 | zone->zone_pgdat->node_present_pages -= offlined_pages; |
1592 | pgdat_resize_unlock(zone->zone_pgdat, &flags); | ||
1593 | |||
1589 | totalram_pages -= offlined_pages; | 1594 | totalram_pages -= offlined_pages; |
1590 | 1595 | ||
1591 | init_per_zone_wmark_min(); | 1596 | init_per_zone_wmark_min(); |