diff options
author | Borislav Petkov <bbpetkov@yahoo.de> | 2007-05-06 17:49:17 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-05-07 15:12:52 -0400 |
commit | 9490991482a2091a828d997adbc088e24c310a4d (patch) | |
tree | dcdd9febee63e82cd792250a8a4c4dd8e6aab4be /mm/memory.c | |
parent | a8127717cb24be7b8827a8d9e0ddbfde6b392146 (diff) |
Add unitialized_var() macro for suppressing gcc warnings
Introduce a macro for suppressing gcc from generating a warning about a
probable uninitialized state of a variable.
Example:
- spinlock_t *ptl;
+ spinlock_t *uninitialized_var(ptl);
Not a happy solution, but those warnings are obnoxious.
- Using the usual pointlessly-set-it-to-zero approach wastes several
bytes of text.
- Using a macro means we can (hopefully) do something else if gcc changes
cause the `x = x' hack to stop working
- Using a macro means that people who are worried about hiding true bugs
can easily turn it off.
Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/memory.c')
-rw-r--r-- | mm/memory.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mm/memory.c b/mm/memory.c index c252aae544e9..1d647ab0ee72 100644 --- a/mm/memory.c +++ b/mm/memory.c | |||
@@ -1455,7 +1455,7 @@ static int apply_to_pte_range(struct mm_struct *mm, pmd_t *pmd, | |||
1455 | pte_t *pte; | 1455 | pte_t *pte; |
1456 | int err; | 1456 | int err; |
1457 | struct page *pmd_page; | 1457 | struct page *pmd_page; |
1458 | spinlock_t *ptl = ptl; /* Suppress gcc warning */ | 1458 | spinlock_t *uninitialized_var(ptl); |
1459 | 1459 | ||
1460 | pte = (mm == &init_mm) ? | 1460 | pte = (mm == &init_mm) ? |
1461 | pte_alloc_kernel(pmd, addr) : | 1461 | pte_alloc_kernel(pmd, addr) : |