diff options
author | Hugh Dickins <hugh.dickins@tiscali.co.uk> | 2009-09-21 20:02:26 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-09-22 10:17:33 -0400 |
commit | a913e182ab9484308e870af37a14d372742d53b0 (patch) | |
tree | 0fca5598aeba4c53999ec46b6b82b46f9a981965 /mm/ksm.c | |
parent | 8314c4f24a0a5c9b1f7544e9fa83a1d5367ddaa7 (diff) |
ksm: clean up obsolete references
A few cleanups, given the munlock fix: the comment on ksm_test_exit() no
longer applies, and it can be made private to ksm.c; there's no more
reference to mmu_gather or tlb.h, and mmap.c doesn't need ksm.h.
Signed-off-by: Hugh Dickins <hugh.dickins@tiscali.co.uk>
Acked-by: Izik Eidus <ieidus@redhat.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/ksm.c')
-rw-r--r-- | mm/ksm.c | 14 |
1 files changed, 13 insertions, 1 deletions
@@ -32,7 +32,6 @@ | |||
32 | #include <linux/mmu_notifier.h> | 32 | #include <linux/mmu_notifier.h> |
33 | #include <linux/ksm.h> | 33 | #include <linux/ksm.h> |
34 | 34 | ||
35 | #include <asm/tlb.h> | ||
36 | #include <asm/tlbflush.h> | 35 | #include <asm/tlbflush.h> |
37 | 36 | ||
38 | /* | 37 | /* |
@@ -285,6 +284,19 @@ static inline int in_stable_tree(struct rmap_item *rmap_item) | |||
285 | } | 284 | } |
286 | 285 | ||
287 | /* | 286 | /* |
287 | * ksmd, and unmerge_and_remove_all_rmap_items(), must not touch an mm's | ||
288 | * page tables after it has passed through ksm_exit() - which, if necessary, | ||
289 | * takes mmap_sem briefly to serialize against them. ksm_exit() does not set | ||
290 | * a special flag: they can just back out as soon as mm_users goes to zero. | ||
291 | * ksm_test_exit() is used throughout to make this test for exit: in some | ||
292 | * places for correctness, in some places just to avoid unnecessary work. | ||
293 | */ | ||
294 | static inline bool ksm_test_exit(struct mm_struct *mm) | ||
295 | { | ||
296 | return atomic_read(&mm->mm_users) == 0; | ||
297 | } | ||
298 | |||
299 | /* | ||
288 | * We use break_ksm to break COW on a ksm page: it's a stripped down | 300 | * We use break_ksm to break COW on a ksm page: it's a stripped down |
289 | * | 301 | * |
290 | * if (get_user_pages(current, mm, addr, 1, 1, 1, &page, NULL) == 1) | 302 | * if (get_user_pages(current, mm, addr, 1, 1, 1, &page, NULL) == 1) |