diff options
author | Joonsoo Kim <iamjoonsoo.kim@lge.com> | 2014-01-21 18:49:49 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-01-21 19:19:45 -0500 |
commit | 0dd1c7bbce8d1d142bb25aefaa50262dfd77cb78 (patch) | |
tree | d45df52098c0a8364a3e614096bb3ee184aeb068 /mm/ksm.c | |
parent | 051ac83adf69eea4f57a97356e4282e395a5fa6d (diff) |
mm/rmap: extend rmap_walk_xxx() to cope with different cases
There are a lot of common parts in traversing functions, but there are
also a little of uncommon parts in it. By assigning proper function
pointer on each rmap_walker_control, we can handle these difference
correctly.
Following are differences we should handle.
1. difference of lock function in anon mapping case
2. nonlinear handling in file mapping case
3. prechecked condition:
checking memcg in page_referenced(),
checking VM_SHARE in page_mkclean()
checking temporary vma in try_to_unmap()
4. exit condition:
checking page_mapped() in try_to_unmap()
So, in this patch, I introduce 4 function pointers to handle above
differences.
Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Hugh Dickins <hughd@google.com>
Cc: Rik van Riel <riel@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Hillf Danton <dhillf@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/ksm.c')
-rw-r--r-- | mm/ksm.c | 7 |
1 files changed, 7 insertions, 0 deletions
@@ -2032,12 +2032,19 @@ again: | |||
2032 | if ((rmap_item->mm == vma->vm_mm) == search_new_forks) | 2032 | if ((rmap_item->mm == vma->vm_mm) == search_new_forks) |
2033 | continue; | 2033 | continue; |
2034 | 2034 | ||
2035 | if (rwc->invalid_vma && rwc->invalid_vma(vma, rwc->arg)) | ||
2036 | continue; | ||
2037 | |||
2035 | ret = rwc->rmap_one(page, vma, | 2038 | ret = rwc->rmap_one(page, vma, |
2036 | rmap_item->address, rwc->arg); | 2039 | rmap_item->address, rwc->arg); |
2037 | if (ret != SWAP_AGAIN) { | 2040 | if (ret != SWAP_AGAIN) { |
2038 | anon_vma_unlock_read(anon_vma); | 2041 | anon_vma_unlock_read(anon_vma); |
2039 | goto out; | 2042 | goto out; |
2040 | } | 2043 | } |
2044 | if (rwc->done && rwc->done(page)) { | ||
2045 | anon_vma_unlock_read(anon_vma); | ||
2046 | goto out; | ||
2047 | } | ||
2041 | } | 2048 | } |
2042 | anon_vma_unlock_read(anon_vma); | 2049 | anon_vma_unlock_read(anon_vma); |
2043 | } | 2050 | } |