mm: introduce kmemleak_update_trace()

The memory allocation stack trace is not always useful for debugging a
memory leak (e.g.  radix_tree_preload).  This function, when called,
updates the stack trace for an already allocated object.

Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

1 files changed, 34 insertions, 0 deletions

diff --git a/mm/kmemleak.c b/mm/kmemleak.c
index 5d4aec44982e..3cda50c1e394 100644
--- a/mm/kmemleak.c
+++ b/mm/kmemleak.c
@@ -990,6 +990,40 @@ void __ref kmemleak_free_percpu(const void __percpu *ptr)
 EXPORT_SYMBOL_GPL(kmemleak_free_percpu);
 
 /**
+ * kmemleak_update_trace - update object allocation stack trace
+ * @ptr:        pointer to beginning of the object
+ *
+ * Override the object allocation stack trace for cases where the actual
+ * allocation place is not always useful.
+ */
+void __ref kmemleak_update_trace(const void *ptr)
+{
+        struct kmemleak_object *object;
+        unsigned long flags;
+
+        pr_debug("%s(0x%p)\n", __func__, ptr);
+
+        if (!kmemleak_enabled || IS_ERR_OR_NULL(ptr))
+                return;
+
+        object = find_and_get_object((unsigned long)ptr, 1);
+        if (!object) {
+#ifdef DEBUG
+                kmemleak_warn("Updating stack trace for unknown object at %p\n",
+                              ptr);
+#endif
+                return;
+        }
+
+        spin_lock_irqsave(&object->lock, flags);
+        object->trace_len = __save_stack_trace(object->trace);
+        spin_unlock_irqrestore(&object->lock, flags);
+
+        put_object(object);
+}
+EXPORT_SYMBOL(kmemleak_update_trace);
+
+/**
  * kmemleak_not_leak - mark an allocated object as false positive
  * @ptr:        pointer to beginning of the object
  *