aboutsummaryrefslogtreecommitdiffstats
path: root/mm/huge_memory.c
diff options
context:
space:
mode:
authorGerald Schaefer <gerald.schaefer@de.ibm.com>2012-10-08 19:30:12 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2012-10-09 03:22:30 -0400
commit8e72033f2a489b6c98c4e3c7cc281b1afd6cb85c (patch)
tree9ac78daf640471e00f3f0fbe22f6c24fb95b8817 /mm/huge_memory.c
parent46dcde735c9d8953bbd8d105ca6779e5b5300c28 (diff)
thp: make MADV_HUGEPAGE check for mm->def_flags
This adds a check to hugepage_madvise(), to refuse MADV_HUGEPAGE if VM_NOHUGEPAGE is set in mm->def_flags. On s390, the VM_NOHUGEPAGE flag will be set in mm->def_flags for kvm processes, to prevent any future thp mappings. In order to also prevent MADV_HUGEPAGE on such an mm, hugepage_madvise() should check mm->def_flags. Signed-off-by: Gerald Schaefer <gerald.schaefer@de.ibm.com> Cc: Andrea Arcangeli <aarcange@redhat.com> Cc: Andi Kleen <ak@linux.intel.com> Cc: Hugh Dickins <hughd@google.com> Cc: Hillf Danton <dhillf@gmail.com> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> Cc: Heiko Carstens <heiko.carstens@de.ibm.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/huge_memory.c')
-rw-r--r--mm/huge_memory.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index bec6243b6965..010d32944d14 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -1450,6 +1450,8 @@ out:
1450int hugepage_madvise(struct vm_area_struct *vma, 1450int hugepage_madvise(struct vm_area_struct *vma,
1451 unsigned long *vm_flags, int advice) 1451 unsigned long *vm_flags, int advice)
1452{ 1452{
1453 struct mm_struct *mm = vma->vm_mm;
1454
1453 switch (advice) { 1455 switch (advice) {
1454 case MADV_HUGEPAGE: 1456 case MADV_HUGEPAGE:
1455 /* 1457 /*
@@ -1457,6 +1459,8 @@ int hugepage_madvise(struct vm_area_struct *vma,
1457 */ 1459 */
1458 if (*vm_flags & (VM_HUGEPAGE | VM_NO_THP)) 1460 if (*vm_flags & (VM_HUGEPAGE | VM_NO_THP))
1459 return -EINVAL; 1461 return -EINVAL;
1462 if (mm->def_flags & VM_NOHUGEPAGE)
1463 return -EINVAL;
1460 *vm_flags &= ~VM_NOHUGEPAGE; 1464 *vm_flags &= ~VM_NOHUGEPAGE;
1461 *vm_flags |= VM_HUGEPAGE; 1465 *vm_flags |= VM_HUGEPAGE;
1462 /* 1466 /*