diff options
author | KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> | 2009-09-21 20:01:33 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-09-22 10:17:27 -0400 |
commit | 4b02108ac1b3354a22b0d83c684797692efdc395 (patch) | |
tree | 9f65d6e8e35ddce940e7b9da6305cf5a19e5904e /mm/filemap.c | |
parent | c6a7f5728a1db45d30df55a01adc130b4ab0327c (diff) |
mm: oom analysis: add shmem vmstat
Recently we encountered OOM problems due to memory use of the GEM cache.
Generally a large amuont of Shmem/Tmpfs pages tend to create a memory
shortage problem.
We often use the following calculation to determine the amount of shmem
pages:
shmem = NR_ACTIVE_ANON + NR_INACTIVE_ANON - NR_ANON_PAGES
however the expression does not consider isolated and mlocked pages.
This patch adds explicit accounting for pages used by shmem and tmpfs.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Acked-by: Rik van Riel <riel@redhat.com>
Reviewed-by: Christoph Lameter <cl@linux-foundation.org>
Acked-by: Wu Fengguang <fengguang.wu@intel.com>
Cc: David Rientjes <rientjes@google.com>
Cc: Hugh Dickins <hugh.dickins@tiscali.co.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/filemap.c')
-rw-r--r-- | mm/filemap.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/mm/filemap.c b/mm/filemap.c index dd51c68e2b86..bcc7372aebbc 100644 --- a/mm/filemap.c +++ b/mm/filemap.c | |||
@@ -119,6 +119,8 @@ void __remove_from_page_cache(struct page *page) | |||
119 | page->mapping = NULL; | 119 | page->mapping = NULL; |
120 | mapping->nrpages--; | 120 | mapping->nrpages--; |
121 | __dec_zone_page_state(page, NR_FILE_PAGES); | 121 | __dec_zone_page_state(page, NR_FILE_PAGES); |
122 | if (PageSwapBacked(page)) | ||
123 | __dec_zone_page_state(page, NR_SHMEM); | ||
122 | BUG_ON(page_mapped(page)); | 124 | BUG_ON(page_mapped(page)); |
123 | 125 | ||
124 | /* | 126 | /* |
@@ -431,6 +433,8 @@ int add_to_page_cache_locked(struct page *page, struct address_space *mapping, | |||
431 | if (likely(!error)) { | 433 | if (likely(!error)) { |
432 | mapping->nrpages++; | 434 | mapping->nrpages++; |
433 | __inc_zone_page_state(page, NR_FILE_PAGES); | 435 | __inc_zone_page_state(page, NR_FILE_PAGES); |
436 | if (PageSwapBacked(page)) | ||
437 | __inc_zone_page_state(page, NR_SHMEM); | ||
434 | spin_unlock_irq(&mapping->tree_lock); | 438 | spin_unlock_irq(&mapping->tree_lock); |
435 | } else { | 439 | } else { |
436 | page->mapping = NULL; | 440 | page->mapping = NULL; |