Fixed bug in edf_higher_prio().prop/robust-tie-break

The rewrite of edf_higher_prio() introduced a bug.  When ALL other
tie-breaks fail (even PIDs are equal), edf_higher_prio() is supposed
to prioritize the task that has an inherited priority.  (At least
one task must have an inherited priority, due to checks earlier in
the function.)  However, the rewrite does the inheritance check
on the inherited priority (second_task), not the original task (second).

This bug can cause G-EDF to fall into an infinite loop in
check_for_preemptions() as scheduling decisions thrash.

1 files changed, 1 insertions, 1 deletions

diff --git a/litmus/edf_common.c b/litmus/edf_common.c
index 52205df3ea8b..bfd3533e8965 100644
--- a/litmus/edf_common.c
+++ b/litmus/edf_common.c
@@ -157,7 +157,7 @@ int edf_higher_prio(struct task_struct* first,
                                 /* If the PIDs are the same then the task with the
                                  * inherited priority wins.
                                  */
-                                if (!second_task->rt_param.inh_task) {
+                                if (!second->rt_param.inh_task) {
                                         return 1;
                                 }
                         }