diff options
author | Eric Dumazet <dada1@cosmosbay.com> | 2008-10-29 14:19:58 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-10-29 14:19:58 -0400 |
commit | 96631ed16c514cf8b28fab991a076985ce378c26 (patch) | |
tree | 60023b60c6eaf2acdc8fcad258585e4425ebaf91 /lib | |
parent | f52b5054ec108aaa9e903850d6b62af8ae3fe6ae (diff) |
udp: introduce sk_for_each_rcu_safenext()
Corey Minyard found a race added in commit 271b72c7fa82c2c7a795bc16896149933110672d
(udp: RCU handling for Unicast packets.)
"If the socket is moved from one list to another list in-between the
time the hash is calculated and the next field is accessed, and the
socket has moved to the end of the new list, the traversal will not
complete properly on the list it should have, since the socket will
be on the end of the new list and there's not a way to tell it's on a
new list and restart the list traversal. I think that this can be
solved by pre-fetching the "next" field (with proper barriers) before
checking the hash."
This patch corrects this problem, introducing a new
sk_for_each_rcu_safenext() macro.
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'lib')
0 files changed, 0 insertions, 0 deletions