diff options
| author | Wu Fengguang <fengguang.wu@intel.com> | 2008-12-10 18:43:17 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2009-01-06 13:44:32 -0500 |
| commit | 2e5ba26a483218b51b7b327fb235b348890aea15 (patch) | |
| tree | 6d90e2cc07fe59b1ead5d5ce3ee24b9d47dc11c1 /lib | |
| parent | 0732b49c8c40c56033cff8986dbad55aa54a5d40 (diff) | |
dynamic_printk: reduce one level of indentation
Cleanup pr_debug_write() to reduce one level of indentation.
Cc: Marcel Holtmann <marcel@holtmann.org>
Acked-by: Jason Baron <jbaron@redhat.com>
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/dynamic_printk.c | 58 |
1 files changed, 26 insertions, 32 deletions
diff --git a/lib/dynamic_printk.c b/lib/dynamic_printk.c index 8e30295e8566..165a19763dc9 100644 --- a/lib/dynamic_printk.c +++ b/lib/dynamic_printk.c | |||
| @@ -277,40 +277,34 @@ static ssize_t pr_debug_write(struct file *file, const char __user *buf, | |||
| 277 | dynamic_enabled = DYNAMIC_ENABLED_NONE; | 277 | dynamic_enabled = DYNAMIC_ENABLED_NONE; |
| 278 | } | 278 | } |
| 279 | err = 0; | 279 | err = 0; |
| 280 | } else { | 280 | } else if (elem) { |
| 281 | if (elem) { | 281 | if (value && (elem->enable == 0)) { |
| 282 | if (value && (elem->enable == 0)) { | 282 | dynamic_printk_enabled |= (1LL << elem->hash1); |
| 283 | dynamic_printk_enabled |= | 283 | dynamic_printk_enabled2 |= (1LL << elem->hash2); |
| 284 | (1LL << elem->hash1); | 284 | elem->enable = 1; |
| 285 | dynamic_printk_enabled2 |= | 285 | num_enabled++; |
| 286 | (1LL << elem->hash2); | 286 | dynamic_enabled = DYNAMIC_ENABLED_SOME; |
| 287 | elem->enable = 1; | 287 | err = 0; |
| 288 | num_enabled++; | 288 | printk(KERN_DEBUG |
| 289 | dynamic_enabled = DYNAMIC_ENABLED_SOME; | 289 | "debugging enabled for module %s\n", |
| 290 | err = 0; | 290 | elem->name); |
| 291 | printk(KERN_DEBUG | 291 | } else if (!value && (elem->enable == 1)) { |
| 292 | "debugging enabled for module %s\n", | 292 | elem->enable = 0; |
| 293 | elem->name); | 293 | num_enabled--; |
| 294 | } else if (!value && (elem->enable == 1)) { | 294 | if (disabled_hash(elem->hash1, true)) |
| 295 | elem->enable = 0; | 295 | dynamic_printk_enabled &= |
| 296 | num_enabled--; | ||
| 297 | if (disabled_hash(elem->hash1, true)) | ||
| 298 | dynamic_printk_enabled &= | ||
| 299 | ~(1LL << elem->hash1); | 296 | ~(1LL << elem->hash1); |
| 300 | if (disabled_hash(elem->hash2, false)) | 297 | if (disabled_hash(elem->hash2, false)) |
| 301 | dynamic_printk_enabled2 &= | 298 | dynamic_printk_enabled2 &= |
| 302 | ~(1LL << elem->hash2); | 299 | ~(1LL << elem->hash2); |
| 303 | if (num_enabled) | 300 | if (num_enabled) |
| 304 | dynamic_enabled = | 301 | dynamic_enabled = DYNAMIC_ENABLED_SOME; |
| 305 | DYNAMIC_ENABLED_SOME; | 302 | else |
| 306 | else | 303 | dynamic_enabled = DYNAMIC_ENABLED_NONE; |
| 307 | dynamic_enabled = | 304 | err = 0; |
| 308 | DYNAMIC_ENABLED_NONE; | 305 | printk(KERN_DEBUG |
| 309 | err = 0; | 306 | "debugging disabled for module %s\n", |
| 310 | printk(KERN_DEBUG | 307 | elem->name); |
| 311 | "debugging disabled for module " | ||
| 312 | "%s\n", elem->name); | ||
| 313 | } | ||
| 314 | } | 308 | } |
| 315 | } | 309 | } |
| 316 | } | 310 | } |