diff options
| author | Robert Richter <robert.richter@amd.com> | 2010-10-15 06:45:00 -0400 |
|---|---|---|
| committer | Robert Richter <robert.richter@amd.com> | 2010-10-15 06:45:00 -0400 |
| commit | 6268464b370e234e0255330190f9bd5d19386ad7 (patch) | |
| tree | 5742641092ce64227dd2086d78baaede57da1f80 /lib | |
| parent | 7df01d96b295e400167e78061b81d4c91630b12d (diff) | |
| parent | 0fdf13606b67f830559abdaad15980c7f4f05ec4 (diff) | |
Merge remote branch 'tip/perf/core' into oprofile/core
Conflicts:
arch/arm/oprofile/common.c
kernel/perf_event.c
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/Kconfig.debug | 8 | ||||
| -rw-r--r-- | lib/bug.c | 6 | ||||
| -rw-r--r-- | lib/dynamic_debug.c | 42 | ||||
| -rw-r--r-- | lib/list_sort.c | 2 |
4 files changed, 10 insertions, 48 deletions
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 1b4afd2e6ca0..e85d549b6eac 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug | |||
| @@ -482,6 +482,7 @@ config PROVE_LOCKING | |||
| 482 | select DEBUG_SPINLOCK | 482 | select DEBUG_SPINLOCK |
| 483 | select DEBUG_MUTEXES | 483 | select DEBUG_MUTEXES |
| 484 | select DEBUG_LOCK_ALLOC | 484 | select DEBUG_LOCK_ALLOC |
| 485 | select TRACE_IRQFLAGS | ||
| 485 | default n | 486 | default n |
| 486 | help | 487 | help |
| 487 | This feature enables the kernel to prove that all locking | 488 | This feature enables the kernel to prove that all locking |
| @@ -579,11 +580,10 @@ config DEBUG_LOCKDEP | |||
| 579 | of more runtime overhead. | 580 | of more runtime overhead. |
| 580 | 581 | ||
| 581 | config TRACE_IRQFLAGS | 582 | config TRACE_IRQFLAGS |
| 582 | depends on DEBUG_KERNEL | ||
| 583 | bool | 583 | bool |
| 584 | default y | 584 | help |
| 585 | depends on TRACE_IRQFLAGS_SUPPORT | 585 | Enables hooks to interrupt enabling and disabling for |
| 586 | depends on PROVE_LOCKING | 586 | either tracing or lock debugging. |
| 587 | 587 | ||
| 588 | config DEBUG_SPINLOCK_SLEEP | 588 | config DEBUG_SPINLOCK_SLEEP |
| 589 | bool "Spinlock debugging: sleep-inside-spinlock checking" | 589 | bool "Spinlock debugging: sleep-inside-spinlock checking" |
| @@ -72,8 +72,8 @@ static const struct bug_entry *module_find_bug(unsigned long bugaddr) | |||
| 72 | return NULL; | 72 | return NULL; |
| 73 | } | 73 | } |
| 74 | 74 | ||
| 75 | int module_bug_finalize(const Elf_Ehdr *hdr, const Elf_Shdr *sechdrs, | 75 | void module_bug_finalize(const Elf_Ehdr *hdr, const Elf_Shdr *sechdrs, |
| 76 | struct module *mod) | 76 | struct module *mod) |
| 77 | { | 77 | { |
| 78 | char *secstrings; | 78 | char *secstrings; |
| 79 | unsigned int i; | 79 | unsigned int i; |
| @@ -97,8 +97,6 @@ int module_bug_finalize(const Elf_Ehdr *hdr, const Elf_Shdr *sechdrs, | |||
| 97 | * could potentially lead to deadlock and thus be counter-productive. | 97 | * could potentially lead to deadlock and thus be counter-productive. |
| 98 | */ | 98 | */ |
| 99 | list_add(&mod->bug_list, &module_bug_list); | 99 | list_add(&mod->bug_list, &module_bug_list); |
| 100 | |||
| 101 | return 0; | ||
| 102 | } | 100 | } |
| 103 | 101 | ||
| 104 | void module_bug_cleanup(struct module *mod) | 102 | void module_bug_cleanup(struct module *mod) |
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 02afc2533728..e925c7b960f1 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c | |||
| @@ -26,19 +26,11 @@ | |||
| 26 | #include <linux/dynamic_debug.h> | 26 | #include <linux/dynamic_debug.h> |
| 27 | #include <linux/debugfs.h> | 27 | #include <linux/debugfs.h> |
| 28 | #include <linux/slab.h> | 28 | #include <linux/slab.h> |
| 29 | #include <linux/jump_label.h> | ||
| 29 | 30 | ||
| 30 | extern struct _ddebug __start___verbose[]; | 31 | extern struct _ddebug __start___verbose[]; |
| 31 | extern struct _ddebug __stop___verbose[]; | 32 | extern struct _ddebug __stop___verbose[]; |
| 32 | 33 | ||
| 33 | /* dynamic_debug_enabled, and dynamic_debug_enabled2 are bitmasks in which | ||
| 34 | * bit n is set to 1 if any modname hashes into the bucket n, 0 otherwise. They | ||
| 35 | * use independent hash functions, to reduce the chance of false positives. | ||
| 36 | */ | ||
| 37 | long long dynamic_debug_enabled; | ||
| 38 | EXPORT_SYMBOL_GPL(dynamic_debug_enabled); | ||
| 39 | long long dynamic_debug_enabled2; | ||
| 40 | EXPORT_SYMBOL_GPL(dynamic_debug_enabled2); | ||
| 41 | |||
| 42 | struct ddebug_table { | 34 | struct ddebug_table { |
| 43 | struct list_head link; | 35 | struct list_head link; |
| 44 | char *mod_name; | 36 | char *mod_name; |
| @@ -88,26 +80,6 @@ static char *ddebug_describe_flags(struct _ddebug *dp, char *buf, | |||
| 88 | } | 80 | } |
| 89 | 81 | ||
| 90 | /* | 82 | /* |
| 91 | * must be called with ddebug_lock held | ||
| 92 | */ | ||
| 93 | |||
| 94 | static int disabled_hash(char hash, bool first_table) | ||
| 95 | { | ||
| 96 | struct ddebug_table *dt; | ||
| 97 | char table_hash_value; | ||
| 98 | |||
| 99 | list_for_each_entry(dt, &ddebug_tables, link) { | ||
| 100 | if (first_table) | ||
| 101 | table_hash_value = dt->ddebugs->primary_hash; | ||
| 102 | else | ||
| 103 | table_hash_value = dt->ddebugs->secondary_hash; | ||
| 104 | if (dt->num_enabled && (hash == table_hash_value)) | ||
| 105 | return 0; | ||
| 106 | } | ||
| 107 | return 1; | ||
| 108 | } | ||
| 109 | |||
| 110 | /* | ||
| 111 | * Search the tables for _ddebug's which match the given | 83 | * Search the tables for _ddebug's which match the given |
| 112 | * `query' and apply the `flags' and `mask' to them. Tells | 84 | * `query' and apply the `flags' and `mask' to them. Tells |
| 113 | * the user which ddebug's were changed, or whether none | 85 | * the user which ddebug's were changed, or whether none |
| @@ -170,17 +142,9 @@ static void ddebug_change(const struct ddebug_query *query, | |||
| 170 | dt->num_enabled++; | 142 | dt->num_enabled++; |
| 171 | dp->flags = newflags; | 143 | dp->flags = newflags; |
| 172 | if (newflags) { | 144 | if (newflags) { |
| 173 | dynamic_debug_enabled |= | 145 | enable_jump_label(&dp->enabled); |
| 174 | (1LL << dp->primary_hash); | ||
| 175 | dynamic_debug_enabled2 |= | ||
| 176 | (1LL << dp->secondary_hash); | ||
| 177 | } else { | 146 | } else { |
| 178 | if (disabled_hash(dp->primary_hash, true)) | 147 | disable_jump_label(&dp->enabled); |
| 179 | dynamic_debug_enabled &= | ||
| 180 | ~(1LL << dp->primary_hash); | ||
| 181 | if (disabled_hash(dp->secondary_hash, false)) | ||
| 182 | dynamic_debug_enabled2 &= | ||
| 183 | ~(1LL << dp->secondary_hash); | ||
| 184 | } | 148 | } |
| 185 | if (verbose) | 149 | if (verbose) |
| 186 | printk(KERN_INFO | 150 | printk(KERN_INFO |
diff --git a/lib/list_sort.c b/lib/list_sort.c index 4b5cb794c38b..a7616fa3162e 100644 --- a/lib/list_sort.c +++ b/lib/list_sort.c | |||
| @@ -70,7 +70,7 @@ static void merge_and_restore_back_links(void *priv, | |||
| 70 | * element comparison is needed, so the client's cmp() | 70 | * element comparison is needed, so the client's cmp() |
| 71 | * routine can invoke cond_resched() periodically. | 71 | * routine can invoke cond_resched() periodically. |
| 72 | */ | 72 | */ |
| 73 | (*cmp)(priv, tail, tail); | 73 | (*cmp)(priv, tail->next, tail->next); |
| 74 | 74 | ||
| 75 | tail->next->prev = tail; | 75 | tail->next->prev = tail; |
| 76 | tail = tail->next; | 76 | tail = tail->next; |
