diff options
author | Daniel Borkmann <dborkman@redhat.com> | 2013-11-12 17:45:42 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-11-14 16:06:02 -0500 |
commit | 0125737accc5aac532719aecd80615364caa9e0f (patch) | |
tree | 2f592b7a2597b93ad262945d3deca0d169ef5e1b /lib | |
parent | 66b251422be7cb39e7619fee647724720f74d1f7 (diff) |
random32: use msecs_to_jiffies for reseed timer
Use msecs_to_jiffies, for these calculations as different HZ
considerations are taken into account for conversion of the timer
shot, and also it makes the code more readable.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'lib')
-rw-r--r-- | lib/random32.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/lib/random32.c b/lib/random32.c index 4f9d5dffc554..1e5b2df44291 100644 --- a/lib/random32.c +++ b/lib/random32.c | |||
@@ -214,18 +214,22 @@ static DEFINE_TIMER(seed_timer, __prandom_timer, 0, 0); | |||
214 | static void __prandom_timer(unsigned long dontcare) | 214 | static void __prandom_timer(unsigned long dontcare) |
215 | { | 215 | { |
216 | u32 entropy; | 216 | u32 entropy; |
217 | unsigned long expires; | ||
217 | 218 | ||
218 | get_random_bytes(&entropy, sizeof(entropy)); | 219 | get_random_bytes(&entropy, sizeof(entropy)); |
219 | prandom_seed(entropy); | 220 | prandom_seed(entropy); |
221 | |||
220 | /* reseed every ~60 seconds, in [40 .. 80) interval with slack */ | 222 | /* reseed every ~60 seconds, in [40 .. 80) interval with slack */ |
221 | seed_timer.expires = jiffies + (40 * HZ + (prandom_u32() % (40 * HZ))); | 223 | expires = 40 + (prandom_u32() % 40); |
224 | seed_timer.expires = jiffies + msecs_to_jiffies(expires * MSEC_PER_SEC); | ||
225 | |||
222 | add_timer(&seed_timer); | 226 | add_timer(&seed_timer); |
223 | } | 227 | } |
224 | 228 | ||
225 | static void __init __prandom_start_seed_timer(void) | 229 | static void __init __prandom_start_seed_timer(void) |
226 | { | 230 | { |
227 | set_timer_slack(&seed_timer, HZ); | 231 | set_timer_slack(&seed_timer, HZ); |
228 | seed_timer.expires = jiffies + 40 * HZ; | 232 | seed_timer.expires = jiffies + msecs_to_jiffies(40 * MSEC_PER_SEC); |
229 | add_timer(&seed_timer); | 233 | add_timer(&seed_timer); |
230 | } | 234 | } |
231 | 235 | ||